Is it typo in pg_stat_replication column name in PG 9.4 ?

Started by Raghavendraover 11 years ago5 messages
#1Raghavendra
raghavendra.rao@enterprisedb.com

Hi,

PostgreSQL 9.4 document for pg_stat_replication view mentions column name
as "backend_xid", whereas when a view described it shows column name as
"backend_xmin".
http://www.postgresql.org/docs/devel/static/monitoring-stats.html#PG-STAT-REPLICATION-VIEW

postgres=# select version();
-[ RECORD 1
]------------------------------------------------------------------------------------------------------------
version | PostgreSQL 9.4beta1 on x86_64-unknown-linux-gnu, compiled by gcc
(GCC) 4.4.7 20120313 (Red Hat 4.4.7-3), 64-bit

postgres=# \d pg_stat_replication
View "pg_catalog.pg_stat_replication"
Column | Type | Modifiers
------------------+--------------------------+-----------
pid | integer |
usesysid | oid |
usename | name |
application_name | text |
client_addr | inet |
client_hostname | text |
client_port | integer |
backend_start | timestamp with time zone |
* backend_xmin* | xid |
state | text |
sent_location | pg_lsn |
write_location | pg_lsn |
flush_location | pg_lsn |
replay_location | pg_lsn |
sync_priority | integer |
sync_state | text |

Is it a typo in pg_stat_replication view column ?

---
Regards,
Raghavendra
EnterpriseDB Corporation
Blog: http://raghavt.blogspot.com/

#2Fabrízio de Royes Mello
fabrizio@timbira.com.br
In reply to: Raghavendra (#1)
1 attachment(s)
Re: [GENERAL] Is it typo in pg_stat_replication column name in PG 9.4 ?

On 18-05-2014 05:40, Raghavendra wrote:

Hi,

PostgreSQL 9.4 document for pg_stat_replication view mentions column name
as "backend_xid", whereas when a view described it shows column name as
"backend_xmin".
http://www.postgresql.org/docs/devel/static/monitoring-stats.html#PG-STAT-REPLICATION-VIEW

postgres=# select version();
-[ RECORD 1
]------------------------------------------------------------------------------------------------------------
version | PostgreSQL 9.4beta1 on x86_64-unknown-linux-gnu, compiled by gcc
(GCC) 4.4.7 20120313 (Red Hat 4.4.7-3), 64-bit

postgres=# \d pg_stat_replication
View "pg_catalog.pg_stat_replication"
Column | Type | Modifiers
------------------+--------------------------+-----------
pid | integer |
usesysid | oid |
usename | name |
application_name | text |
client_addr | inet |
client_hostname | text |
client_port | integer |
backend_start | timestamp with time zone |
* backend_xmin* | xid |
state | text |
sent_location | pg_lsn |
write_location | pg_lsn |
flush_location | pg_lsn |
replay_location | pg_lsn |
sync_priority | integer |
sync_state | text |

Is it a typo in pg_stat_replication view column ?

Hi,

I think this is an incorrect list... moving to pgsql-hackers

And yes, this seems to be a typo. Patch attached!

Regards,

--
Fabrízio de Royes Mello Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachments:

typo-doc-pg_stat_replication.patchtext/x-diff; name=typo-doc-pg_stat_replication.patchDownload
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index ffdf0c5..1c05243 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -1494,7 +1494,7 @@ postgres: <replaceable>user</> <replaceable>database</> <replaceable>host</> <re
      </entry>
     </row>
     <row>
-     <entry><structfield>backend_xid</structfield></entry>
+     <entry><structfield>backend_xmin</structfield></entry>
      <entry><type>xid</type></entry>
      <entry>This standby's <literal>xmin</> horizon reported
      by <xref linkend="guc-hot-standby-feedback">.</entry>
#3Fujii Masao
masao.fujii@gmail.com
In reply to: Fabrízio de Royes Mello (#2)
Re: Re: [GENERAL] Is it typo in pg_stat_replication column name in PG 9.4 ?

On Mon, May 19, 2014 at 10:05 AM, Fabrízio de Royes Mello
<fabrizio@timbira.com.br> wrote:

On 18-05-2014 05:40, Raghavendra wrote:

Hi,

PostgreSQL 9.4 document for pg_stat_replication view mentions column name
as "backend_xid", whereas when a view described it shows column name as
"backend_xmin".
http://www.postgresql.org/docs/devel/static/monitoring-stats.html#PG-STAT-REPLICATION-VIEW

postgres=# select version();
-[ RECORD 1
]------------------------------------------------------------------------------------------------------------
version | PostgreSQL 9.4beta1 on x86_64-unknown-linux-gnu, compiled by gcc
(GCC) 4.4.7 20120313 (Red Hat 4.4.7-3), 64-bit

postgres=# \d pg_stat_replication
View "pg_catalog.pg_stat_replication"
Column | Type | Modifiers
------------------+--------------------------+-----------
pid | integer |
usesysid | oid |
usename | name |
application_name | text |
client_addr | inet |
client_hostname | text |
client_port | integer |
backend_start | timestamp with time zone |
* backend_xmin* | xid |
state | text |
sent_location | pg_lsn |
write_location | pg_lsn |
flush_location | pg_lsn |
replay_location | pg_lsn |
sync_priority | integer |
sync_state | text |

Is it a typo in pg_stat_replication view column ?

Hi,

I think this is an incorrect list... moving to pgsql-hackers

And yes, this seems to be a typo. Patch attached!

Thanks! Applied.

Regards,

--
Fujii Masao

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Raghavendra
raghavendra.rao@enterprisedb.com
In reply to: Fabrízio de Royes Mello (#2)
Re: Re: [GENERAL] Is it typo in pg_stat_replication column name in PG 9.4 ?


On Mon, May 19, 2014 at 6:35 AM, Fabrízio de Royes Mello <
fabrizio@timbira.com.br> wrote:

On 18-05-2014 05:40, Raghavendra wrote:

Hi,

PostgreSQL 9.4 document for pg_stat_replication view mentions column name
as "backend_xid", whereas when a view described it shows column name as
"backend_xmin".

http://www.postgresql.org/docs/devel/static/monitoring-stats.html#PG-STAT-REPLICATION-VIEW

postgres=# select version();
-[ RECORD 1

]------------------------------------------------------------------------------------------------------------

version | PostgreSQL 9.4beta1 on x86_64-unknown-linux-gnu, compiled by

gcc

(GCC) 4.4.7 20120313 (Red Hat 4.4.7-3), 64-bit

postgres=# \d pg_stat_replication
View "pg_catalog.pg_stat_replication"
Column | Type | Modifiers
------------------+--------------------------+-----------
pid | integer |
usesysid | oid |
usename | name |
application_name | text |
client_addr | inet |
client_hostname | text |
client_port | integer |
backend_start | timestamp with time zone |
* backend_xmin* | xid |
state | text |
sent_location | pg_lsn |
write_location | pg_lsn |
flush_location | pg_lsn |
replay_location | pg_lsn |
sync_priority | integer |
sync_state | text |

Is it a typo in pg_stat_replication view column ?

Hi,

I think this is an incorrect list... moving to pgsql-hackers

Noted..! Thank you. I will take care in my future posting.

​--Raghav​

And yes, this seems to be a typo. Patch attached!

Show quoted text

Regards,

--
Fabrízio de Royes Mello Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Bruce Momjian
bruce@momjian.us
In reply to: Raghavendra (#1)
Re: Is it typo in pg_stat_replication column name in PG 9.4 ?

On Sun, May 18, 2014 at 02:10:53PM +0530, Raghavendra wrote:

Hi,

PostgreSQL 9.4 document for pg_stat_replication view mentions column name as
"backend_xid", whereas when a view described it shows column name as
"backend_xmin".
http://www.postgresql.org/docs/devel/static/monitoring-stats.html#
PG-STAT-REPLICATION-VIEW

postgres=# select version();
-[ RECORD 1 ]
------------------------------------------------------------------------------------------------------------
�version | PostgreSQL 9.4beta1 on x86_64-unknown-linux-gnu, compiled by gcc
(GCC) 4.4.7 20120313 (Red Hat 4.4.7-3), 64-bit

postgres=# \d pg_stat_replication
� � � � � View "pg_catalog.pg_stat_replication"
� � � Column � � �| � � � � � Type � � � � � | Modifiers
------------------+--------------------------+-----------
�pid � � � � � � �| integer � � � � � � � � �|
�usesysid � � � � | oid � � � � � � � � � � �|
�usename � � � � �| name � � � � � � � � � � |
�application_name | text � � � � � � � � � � |
�client_addr � � �| inet � � � � � � � � � � |
�client_hostname �| text � � � � � � � � � � |
�client_port � � �| integer � � � � � � � � �|
�backend_start � �| timestamp with time zone |
�backend_xmin � � | xid � � � � � � � � � � �|
�state � � � � � �| text � � � � � � � � � � |
�sent_location � �| pg_lsn � � � � � � � � � |
�write_location � | pg_lsn � � � � � � � � � |
�flush_location � | pg_lsn � � � � � � � � � |
�replay_location �| pg_lsn � � � � � � � � � |
�sync_priority � �| integer � � � � � � � � �|
�sync_state � � � | text � � � � � � � � � � |

Is it a typo in pg_stat_replication view column ?

This has been fixed by this commit:

commit eb56812144bb310f7cb2f63e53d6d58f30df95b5
Author: Fujii Masao <fujii@postgresql.org>
Date: Mon May 19 17:03:30 2014 +0900

Fix incorrect column name in pg_stat_replication document.

Fabr�zio de Royes Mello

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general