Typo fixes in Solution.pm, part of MSVC scripts
Hi all,
I noticed a couple of typos in Solution.pm, fixed by the patch
attached. Those things have been introduced by commits cec8394 (visual
2013 support) and 0a78320 (latest pgident run, not actually a problem
of pgident, because of a misuse of commas).
The tab problems should not be backpatched to 9.3, but the use of
commas instead of semicolons should be.
Regards,
--
Michael
Attachments:
20140526_msvc_typos.patchtext/x-patch; charset=US-ASCII; name=20140526_msvc_typos.patchDownload
diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
index 283d399..c0d7f38 100644
--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -747,13 +747,13 @@ sub new
my $self = $classname->SUPER::_new(@_);
bless($self, $classname);
- $self->{solutionFileVersion} = '12.00';
- $self->{vcver} = '12.00';
- $self->{visualStudioName} = 'Visual Studio 2013';
- $self->{VisualStudioVersion} = '12.0.21005.1',
- $self->{MinimumVisualStudioVersion} = '10.0.40219.1',
+ $self->{solutionFileVersion} = '12.00';
+ $self->{vcver} = '12.00';
+ $self->{visualStudioName} = 'Visual Studio 2013';
+ $self->{VisualStudioVersion} = '12.0.21005.1';
+ $self->{MinimumVisualStudioVersion} = '10.0.40219.1';
- return $self;
+ return $self;
}
sub GetAdditionalHeaders
Michael Paquier <michael.paquier@gmail.com> writes:
I noticed a couple of typos in Solution.pm, fixed by the patch
attached.
I think you meant to send this to the main -hackers list?
regards, tom lane
--
Sent via pgsql-odbc mailing list (pgsql-odbc@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-odbc
Hi all,
I noticed a couple of typos in Solution.pm, fixed by the patch
attached. Those things have been introduced by commits cec8394 (visual
2013 support) and 0a78320 (latest pgident run, not actually a problem
of pgident, because of a misuse of commas).
The tab problems should not be backpatched to 9.3, but the use of
commas instead of semicolons should be.
Regards,
--
Michael
Attachments:
20140526_msvc_typos.patchtext/x-patch; charset=US-ASCII; name=20140526_msvc_typos.patchDownload
diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
index 283d399..c0d7f38 100644
--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -747,13 +747,13 @@ sub new
my $self = $classname->SUPER::_new(@_);
bless($self, $classname);
- $self->{solutionFileVersion} = '12.00';
- $self->{vcver} = '12.00';
- $self->{visualStudioName} = 'Visual Studio 2013';
- $self->{VisualStudioVersion} = '12.0.21005.1',
- $self->{MinimumVisualStudioVersion} = '10.0.40219.1',
+ $self->{solutionFileVersion} = '12.00';
+ $self->{vcver} = '12.00';
+ $self->{visualStudioName} = 'Visual Studio 2013';
+ $self->{VisualStudioVersion} = '12.0.21005.1';
+ $self->{MinimumVisualStudioVersion} = '10.0.40219.1';
- return $self;
+ return $self;
}
sub GetAdditionalHeaders
On Mon, May 26, 2014 at 12:08 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Michael Paquier <michael.paquier@gmail.com> writes:
I noticed a couple of typos in Solution.pm, fixed by the patch
attached.I think you meant to send this to the main -hackers list?
Oops. Sorry. Thanks for noticing.
--
Michael
--
Sent via pgsql-odbc mailing list (pgsql-odbc@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-odbc
On Sun, May 25, 2014 at 11:34 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
I noticed a couple of typos in Solution.pm, fixed by the patch
attached. Those things have been introduced by commits cec8394 (visual
2013 support) and 0a78320 (latest pgident run, not actually a problem
of pgident, because of a misuse of commas).
The tab problems should not be backpatched to 9.3, but the use of
commas instead of semicolons should be.
I suspect it would be good, then, to separate this into two patches,
one for back-patch and one not.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, May 30, 2014 at 4:31 AM, Robert Haas <robertmhaas@gmail.com> wrote:
I suspect it would be good, then, to separate this into two patches,
one for back-patch and one not.
Attached are patches for master and 9.3. 9.2 and older versions are
not impacted.
Regards,
--
Michael
Attachments:
20140530_msvc_typos_93.patchtext/x-patch; charset=US-ASCII; name=20140530_msvc_typos_93.patchDownload
diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
index 9c4e9f7..473185f 100644
--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -756,8 +756,8 @@ sub new
$self->{solutionFileVersion} = '12.00';
$self->{vcver} = '12.00';
$self->{visualStudioName} = 'Visual Studio 2013';
- $self->{VisualStudioVersion} = '12.0.21005.1',
- $self->{MinimumVisualStudioVersion} = '10.0.40219.1',
+ $self->{VisualStudioVersion} = '12.0.21005.1';
+ $self->{MinimumVisualStudioVersion} = '10.0.40219.1';
return $self;
}
20140530_msvc_typos_master.patchtext/x-patch; charset=US-ASCII; name=20140530_msvc_typos_master.patchDownload
diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
index 283d399..c0d7f38 100644
--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -747,13 +747,13 @@ sub new
my $self = $classname->SUPER::_new(@_);
bless($self, $classname);
- $self->{solutionFileVersion} = '12.00';
- $self->{vcver} = '12.00';
- $self->{visualStudioName} = 'Visual Studio 2013';
- $self->{VisualStudioVersion} = '12.0.21005.1',
- $self->{MinimumVisualStudioVersion} = '10.0.40219.1',
+ $self->{solutionFileVersion} = '12.00';
+ $self->{vcver} = '12.00';
+ $self->{visualStudioName} = 'Visual Studio 2013';
+ $self->{VisualStudioVersion} = '12.0.21005.1';
+ $self->{MinimumVisualStudioVersion} = '10.0.40219.1';
- return $self;
+ return $self;
}
sub GetAdditionalHeaders
On 05/30/2014 10:25 AM, Michael Paquier wrote:
On Fri, May 30, 2014 at 4:31 AM, Robert Haas <robertmhaas@gmail.com> wrote:
I suspect it would be good, then, to separate this into two patches,
one for back-patch and one not.Attached are patches for master and 9.3. 9.2 and older versions are
not impacted.
Thanks, applied.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers