unused local variable

Started by Kevin Grittneralmost 12 years ago3 messageshackers
Jump to latest
#1Kevin Grittner
Kevin.Grittner@wicourts.gov

Commit 8b6010b8350a1756cd85595705971df81b5ffc07 eliminated the only
usage of a variable called typeStruct in plpy_spi.c, but left the
declaration and the code that sets a value for it.  This is
generating a warning when I build.  I would have just pushed a fix,
but I was concerned that it might have been left on purpose for
some follow-on patch. Any objections to the attached, to silence
the warning?

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachments:

typeStruct.difftext/x-diff; name=typeStruct.diffDownload+0-2
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Kevin Grittner (#1)
Re: unused local variable

Kevin Grittner <kgrittn@ymail.com> writes:

Commit 8b6010b8350a1756cd85595705971df81b5ffc07 eliminated the only
usage of a variable called typeStruct in plpy_spi.c, but left the
declaration and the code that sets a value for it.� This is
generating a warning when I build.� I would have just pushed a fix,
but I was concerned that it might have been left on purpose for
some follow-on patch. Any objections to the attached, to silence
the warning?

Huh. Odd that I did not see such a warning here. No objection to
removing the dead variable.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Kevin Grittner
Kevin.Grittner@wicourts.gov
In reply to: Tom Lane (#2)
Re: unused local variable

Tom Lane <tgl@sss.pgh.pa.us> wrote:

Kevin Grittner <kgrittn@ymail.com> writes:

typeStruct in plpy_spi.c

No objection to removing the dead variable.

Done.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers