Missing autocomplete for CREATE DATABASE
It seems psql is missing autocomplete entries for LC_COLLATE and
LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.
I doubt this is important enough to backpatch - thoughts?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Attachments:
psql_locale_autocomplete.patchtext/x-patch; charset=US-ASCII; name=psql_locale_autocomplete.patchDownload
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 3bb727f..f746ddc 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -2046,7 +2046,7 @@ psql_completion(const char *text, int start, int end)
{
static const char *const list_DATABASE[] =
{"OWNER", "TEMPLATE", "ENCODING", "TABLESPACE", "CONNECTION LIMIT",
- NULL};
+ "LC_COLLATE", "LC_CTYPE", NULL};
COMPLETE_WITH_LIST(list_DATABASE);
}
On 07/10/2014 09:32 PM, Magnus Hagander wrote:
It seems psql is missing autocomplete entries for LC_COLLATE and
LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.I doubt this is important enough to backpatch - thoughts?
It won't apply to current head, but otherwise I see no problem with it.
I have no opinion on backpatching it.
--
Vik
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Jul 10, 2014 at 08:32:01PM +0100, Magnus Hagander wrote:
It seems psql is missing autocomplete entries for LC_COLLATE and
LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.I doubt this is important enough to backpatch - thoughts?
I don't see how it could hurt to fix this bug.
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Jul 11, 2014 at 12:01 AM, Vik Fearing <vik.fearing@dalibo.com> wrote:
On 07/10/2014 09:32 PM, Magnus Hagander wrote:
It seems psql is missing autocomplete entries for LC_COLLATE and
LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.I doubt this is important enough to backpatch - thoughts?
It won't apply to current head, but otherwise I see no problem with it.
Meh, thanks for pointing that out. I git-fetch:ed from the wrong repository :)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Jul 11, 2014 at 1:10 PM, Magnus Hagander <magnus@hagander.net> wrote:
On Fri, Jul 11, 2014 at 12:01 AM, Vik Fearing <vik.fearing@dalibo.com> wrote:
On 07/10/2014 09:32 PM, Magnus Hagander wrote:
It seems psql is missing autocomplete entries for LC_COLLATE and
LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.I doubt this is important enough to backpatch - thoughts?
It won't apply to current head, but otherwise I see no problem with it.
Meh, thanks for pointing that out. I git-fetch:ed from the wrong repository :)
Applied and backpatched.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers