pgsql: Diagnose incompatible OpenLDAP versions during build and test.
Diagnose incompatible OpenLDAP versions during build and test.
With OpenLDAP versions 2.4.24 through 2.4.31, inclusive, PostgreSQL
backends can crash at exit. Raise a warning during "configure" based on
the compile-time OpenLDAP version number, and test the crash scenario in
the dblink test suite. Back-patch to 9.0 (all supported versions).
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/d7cdf6ee36adeac9233678fb8f2a112e6678a770
Modified Files
--------------
configure | 52 ++++++++++++++++++++++++++++++++++++
configure.in | 29 ++++++++++++++++++++
contrib/dblink/Makefile | 4 ++-
contrib/dblink/expected/.gitignore | 1 +
contrib/dblink/expected/dblink.out | 27 +++++++++++++++++++
contrib/dblink/input/paths.source | 14 ++++++++++
contrib/dblink/output/paths.source | 11 ++++++++
contrib/dblink/pg_service.conf | 7 +++++
contrib/dblink/sql/.gitignore | 1 +
contrib/dblink/sql/dblink.sql | 28 +++++++++++++++++++
src/test/regress/regress.c | 43 +++++++++++++++++++++++++++++
11 files changed, 216 insertions(+), 1 deletion(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Noah Misch <noah@leadboat.com> writes:
Diagnose incompatible OpenLDAP versions during build and test.
Hmm. I'm pretty sure it is not considered good style to drop AC_DEFUN
blocks right into configure.in; at least, we have never done that before.
PGAC_LDAP_SAFE should get defined somewhere in config/*.m4, instead.
I am not real sure however which existing config/ file is appropriate,
or whether we should create a new one. Peter, any opinion?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
Diagnose incompatible OpenLDAP versions during build and test.
Oh, one more thing: the Windows buildfarm members mostly don't like
the dblink test case you added. Looks like the mechanism for finding
the shared library doesn't work.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Jul 22, 2014 at 11:51:18AM -0400, Tom Lane wrote:
Noah Misch <noah@leadboat.com> writes:
Diagnose incompatible OpenLDAP versions during build and test.
Hmm. I'm pretty sure it is not considered good style to drop AC_DEFUN
blocks right into configure.in; at least, we have never done that before.
PGAC_LDAP_SAFE should get defined somewhere in config/*.m4, instead.
I am not real sure however which existing config/ file is appropriate,
or whether we should create a new one. Peter, any opinion?
I don't mind reinstating the absence of AC_DEFUN from configure.in. Add
config/misc-libraries.m4, perhaps? Alternately, stretch programs.m4; it
already has two readline library checks.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
On Tue, Jul 22, 2014 at 11:51:18AM -0400, Tom Lane wrote:
Hmm. I'm pretty sure it is not considered good style to drop AC_DEFUN
blocks right into configure.in; at least, we have never done that before.
PGAC_LDAP_SAFE should get defined somewhere in config/*.m4, instead.
I am not real sure however which existing config/ file is appropriate,
or whether we should create a new one. Peter, any opinion?
I don't mind reinstating the absence of AC_DEFUN from configure.in. Add
config/misc-libraries.m4, perhaps? Alternately, stretch programs.m4; it
already has two readline library checks.
programs.m4 sounds like the place then.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers