"port/atomics/arch-*.h" are missing from installation
I got the following error when I try to build my extension
towards the latest master branch.
Is the "port/atomics/*.h" files forgotten on make install?
[kaigai@magro pg_strom]$ make
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -fexcess-precision=standard -g -fpic -Wall -O0
-DPGSTROM_DEBUG=1 -I. -I./ -I/usr/local/pgsql/include/server
-I/usr/local/pgsql/include/internal -D_GNU_SOURCE -c -o shmem.o
shmem.c
In file included from /usr/local/pgsql/include/server/storage/barrier.h:21:0,
from shmem.c:18:
/usr/local/pgsql/include/server/port/atomics.h:65:36: fatal error:
port/atomics/arch-x86.h: No such file or directory
# include "port/atomics/arch-x86.h"
^
compilation terminated.
make: *** [shmem.o] Error 1
Even though the source directory has header files...
[kaigai@magro sepgsql]$ find ./src | grep atomics
./src/include/port/atomics
./src/include/port/atomics/generic-xlc.h
./src/include/port/atomics/arch-x86.h
./src/include/port/atomics/generic-acc.h
./src/include/port/atomics/arch-ppc.h
./src/include/port/atomics/generic.h
./src/include/port/atomics/arch-hppa.h
./src/include/port/atomics/generic-msvc.h
./src/include/port/atomics/arch-ia64.h
./src/include/port/atomics/generic-sunpro.h
./src/include/port/atomics/arch-arm.h
./src/include/port/atomics/generic-gcc.h
./src/include/port/atomics/fallback.h
./src/include/port/atomics.h
./src/backend/port/atomics.c
the install destination has only atomics.h
[kaigai@magro sepgsql]$ find /usr/local/pgsql/include | grep atomics
/usr/local/pgsql/include/server/port/atomics.h
The attached patch is probably right remedy.
Thanks,
--
KaiGai Kohei <kaigai@kaigai.gr.jp>
Attachments:
pgsql-v9.5-fixup-makefile-for-atomics.patchapplication/octet-stream; name=pgsql-v9.5-fixup-makefile-for-atomics.patchDownload
diff --git a/src/include/Makefile b/src/include/Makefile
index 578a778..b707fd5 100644
--- a/src/include/Makefile
+++ b/src/include/Makefile
@@ -22,7 +22,7 @@ SUBDIRS = access bootstrap catalog commands common datatype executor foreign \
rewrite storage tcop snowball snowball/libstemmer tsearch \
tsearch/dicts utils port port/win32 port/win32_msvc \
port/win32_msvc/sys port/win32/arpa port/win32/netinet \
- port/win32/sys portability
+ port/win32/sys port/atomics portability
# Install all headers
install: all installdirs
Hi,
On 2014-10-02 23:33:36 +0900, Kohei KaiGai wrote:
I got the following error when I try to build my extension
towards the latest master branch.Is the "port/atomics/*.h" files forgotten on make install?
You're right.
The attached patch is probably right remedy.
I've changed the order to be alphabetic, but otherwise it looks
good. Pushed.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers