Typos in CREATE TABLE doc

Started by Etsuro Fujitaover 11 years ago5 messageshackers
Jump to latest
#1Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp

It seems to me there are typos in the reference page for CREATE TABLE.
Please find attached a patch.

Thanks,

Best regards,
Etsuro Fujita

Attachments:

createtable_typofix.patchtext/x-diff; name=createtable_typofix.patchDownload+2-2
#2Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Etsuro Fujita (#1)
Re: Typos in CREATE TABLE doc

On 11/13/2014 12:45 PM, Etsuro Fujita wrote:

It seems to me there are typos in the reference page for CREATE TABLE.

The structure of the sentence is a bit funky, but it seems correct to
me. If you google for "should any", you'll get a bunch of pages
discussing similar sentences.

I would add a comma there, though: "Should any row of an insert or
update operation produce a FALSE result, an exception is raised and ..."

- Heikki

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
In reply to: Heikki Linnakangas (#2)
Re: Typos in CREATE TABLE doc

(2014/11/13 20:07), Heikki Linnakangas wrote:

On 11/13/2014 12:45 PM, Etsuro Fujita wrote:

It seems to me there are typos in the reference page for CREATE TABLE.

The structure of the sentence is a bit funky, but it seems correct to
me. If you google for "should any", you'll get a bunch of pages
discussing similar sentences.

I would add a comma there, though: "Should any row of an insert or
update operation produce a FALSE result, an exception is raised and ..."

I understand. So, Here is the comma patch.

Thanks,

Best regards,
Etsuro Fujita

Attachments:

doc_add_comma.patchtext/x-diff; name=doc_add_comma.patchDownload+1-1
#4Bruce Momjian
bruce@momjian.us
In reply to: Etsuro Fujita (#3)
Re: Typos in CREATE TABLE doc

On Thu, Nov 13, 2014 at 08:30:49PM +0900, Etsuro Fujita wrote:

(2014/11/13 20:07), Heikki Linnakangas wrote:

On 11/13/2014 12:45 PM, Etsuro Fujita wrote:

It seems to me there are typos in the reference page for CREATE TABLE.

The structure of the sentence is a bit funky, but it seems correct to
me. If you google for "should any", you'll get a bunch of pages
discussing similar sentences.

I would add a comma there, though: "Should any row of an insert or
update operation produce a FALSE result, an exception is raised and ..."

I understand. So, Here is the comma patch.

Patch applied.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
In reply to: Bruce Momjian (#4)
Re: Typos in CREATE TABLE doc

On 2015/03/21 5:58, Bruce Momjian wrote:

On Thu, Nov 13, 2014 at 08:30:49PM +0900, Etsuro Fujita wrote:

(2014/11/13 20:07), Heikki Linnakangas wrote:

On 11/13/2014 12:45 PM, Etsuro Fujita wrote:

It seems to me there are typos in the reference page for CREATE TABLE.

The structure of the sentence is a bit funky, but it seems correct to
me. If you google for "should any", you'll get a bunch of pages
discussing similar sentences.

I would add a comma there, though: "Should any row of an insert or
update operation produce a FALSE result, an exception is raised and ..."

I understand. So, Here is the comma patch.

Patch applied.

Thanks!

Best regards,
Etsuro Fujita

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers