A possbile typo in src/bin/pg_dump.c

Started by Amit Langoteabout 11 years ago2 messages

Langote_Amit_f8@lab.ntt.co.jp

about 11 years ago

1 attachment(s)

Hi,

I found in pg_dump.c what I believe to be a typo.

-                * relationships are set up by doing ALTER INHERIT rather than
using
+                * relationships are set up by doing ALTER TABLE INHERIT
rather than using

Attached fixes this if appropriate to do so.

Thanks,
Amit

Attachments:

20141125-bin-pg_dump-typo.patchapplication/octet-stream; name=20141125-bin-pg_dump-typo.patchDownload

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 69d3594..1d73523 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -13780,7 +13780,7 @@ dumpTableSchema(Archive *fout, DumpOptions *dopt, TableInfo *tbinfo)
 		 * here, also updating their attlen/attalign values so that the
 		 * dropped column can be skipped properly.  (We do not bother with
 		 * restoring the original attbyval setting.)  Also, inheritance
-		 * relationships are set up by doing ALTER INHERIT rather than using
+		 * relationships are set up by doing ALTER TABLE INHERIT rather than using
 		 * an INHERITS clause --- the latter would possibly mess up the column
 		 * order.  That also means we have to take care about setting
 		 * attislocal correctly, plus fix up any inherited CHECK constraints.

Bruce Momjian

bruce@momjian.us

almost 11 years ago

In reply to: Amit Langote (#1)

Re: A possbile typo in src/bin/pg_dump.c

On Tue, Nov 25, 2014 at 02:45:00PM +0900, Amit Langote wrote:

Hi,

I found in pg_dump.c what I believe to be a typo.
-                * relationships are set up by doing ALTER INHERIT rather than
using
+                * relationships are set up by doing ALTER TABLE INHERIT
rather than using
Attached fixes this if appropriate to do so.

Thanks, patch applied.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers