SET QUERY_LIMIT bug report

Started by José Soaresover 26 years ago8 messages
#1José Soares
jose@sferacarta.com

I see there's still the command:

SET QUERY_LIMIT (even in the docs)
but it doesn't work.
prova=> select * from test limit 1;
num|flt8
----+----
1.00| 1
(1 row)

prova=>
prova=> set query_limit = '1';
SET VARIABLE
prova=> select * from test;
num| flt8
-----+-----
1.00| 1
2.34|2.343
-3.00| -3
(3 rows)

prova=> show query_limit;
NOTICE: query limit is 1
SHOW VARIABLE

--
______________________________________________________________
PostgreSQL 6.5.0 on i586-pc-linux-gnu, compiled by gcc 2.7.2.3
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Jose'

#2Bruce Momjian
maillist@candle.pha.pa.us
In reply to: José Soares (#1)
Re: [HACKERS] SET QUERY_LIMIT bug report

I see there's still the command:

SET QUERY_LIMIT (even in the docs)
but it doesn't work.
prova=> select * from test limit 1;
num|flt8
----+----
1.00| 1
(1 row)

Yep, broken:

test=> set query_limit = '1';
SET VARIABLE
test=> select * from pg_language;
lanname |lanispl|lanpltrusted|lanplcallfoid|lancompiler
--------+-------+------------+-------------+--------------
internal|f |f | 0|n/a
lisp |f |f | 0|/usr/ucb/liszt
C |f |f | 0|/bin/cc
sql |f |f | 0|postgres

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#2)
Re: [HACKERS] SET QUERY_LIMIT bug report

I had the idea we were going to remove QUERY_LIMIT now that we have
the LIMIT clause? There were good arguments advanced that QUERY_LIMIT
is actually dangerous, since it could (for example) prevent trigger
rules from operating as intended.

regards, tom lane

#4Bruce Momjian
maillist@candle.pha.pa.us
In reply to: Tom Lane (#3)
Re: [HACKERS] SET QUERY_LIMIT bug report

I had the idea we were going to remove QUERY_LIMIT now that we have
the LIMIT clause? There were good arguments advanced that QUERY_LIMIT
is actually dangerous, since it could (for example) prevent trigger
rules from operating as intended.

regards, tom lane

OK. Easily removed, especially since it doesn't work.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#5Tatsuo Ishii
t-ishii@sra.co.jp
In reply to: Bruce Momjian (#4)
Re: [HACKERS] SET QUERY_LIMIT bug report

I had the idea we were going to remove QUERY_LIMIT now that we have
the LIMIT clause? There were good arguments advanced that QUERY_LIMIT
is actually dangerous, since it could (for example) prevent trigger
rules from operating as intended.

Yes. We should remove set query_limit before 6.5.1...
--
Tatsuo Ishii

#6Bruce Momjian
maillist@candle.pha.pa.us
In reply to: Tatsuo Ishii (#5)
Re: [HACKERS] SET QUERY_LIMIT bug report

I had the idea we were going to remove QUERY_LIMIT now that we have
the LIMIT clause? There were good arguments advanced that QUERY_LIMIT
is actually dangerous, since it could (for example) prevent trigger
rules from operating as intended.

Yes. We should remove set query_limit before 6.5.1...
--
Tatsuo Ishii

Agreed.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#7José Soares
jose@sferacarta.com
In reply to: Bruce Momjian (#4)
Re: [HACKERS] SET QUERY_LIMIT bug report

Bruce Momjian ha scritto:

I had the idea we were going to remove QUERY_LIMIT now that we have
the LIMIT clause? There were good arguments advanced that QUERY_LIMIT
is actually dangerous, since it could (for example) prevent trigger
rules from operating as intended.

regards, tom lane

OK. Easily removed, especially since it doesn't work.

We need to remove it even from docs.
(psql help, user guide and man pages)

Jose'

#8Bruce Momjian
maillist@candle.pha.pa.us
In reply to: José Soares (#7)
Re: [HACKERS] SET QUERY_LIMIT bug report

Bruce Momjian ha scritto:

I had the idea we were going to remove QUERY_LIMIT now that we have
the LIMIT clause? There were good arguments advanced that QUERY_LIMIT
is actually dangerous, since it could (for example) prevent trigger
rules from operating as intended.

regards, tom lane

OK. Easily removed, especially since it doesn't work.

We need to remove it even from docs.
(psql help, user guide and man pages)

Yes, that will be done too.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026