XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine

On 12/05/2014 04:54 AM, Michael Paquier wrote:

Hi all,

While reading the code in this area this morning, I noticed that
wal_log_hints and track_commit_timestamp are not mentioned in the desc
routine of XLOG_CHANGE_PARAMETER. Also, it is not mentioned in
postgresql.conf.sample that a value update of wal_log_hints requires a
system restart.

In order to fix those things, attached are two patches:
- patch 1 should be applied back to 9.4 where wal_log_hints has been added

You got the wal_level and wal_log_hints strings backwards:

rmgr: XLOG len (rec/tot): 24/ 50, tx: 0, lsn:
0/07172488, prev 0/07172418, desc: PARAMETER_CHANGE max_connections=100
max_worker_processes=8 max_prepared_xacts=0 max_locks_per_xact=64
wal_level=false wal_log_hints=hot_standby

Fixed that, and changed "true"/"false" to "on"/"off", as that's more
common phrasing for boolean GUCs.

- patch 2 is master-only, and needs to be applied on top of patch 1.

Same here.

Committed both patches with those fixes, thanks!

- Heikki

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Fri, Dec 5, 2014 at 7:12 PM, Heikki Linnakangas <hlinnakangas@vmware.com>
wrote:

On 12/05/2014 04:54 AM, Michael Paquier wrote:

Hi all,

While reading the code in this area this morning, I noticed that
wal_log_hints and track_commit_timestamp are not mentioned in the desc
routine of XLOG_CHANGE_PARAMETER. Also, it is not mentioned in
postgresql.conf.sample that a value update of wal_log_hints requires a
system restart.

In order to fix those things, attached are two patches:
- patch 1 should be applied back to 9.4 where wal_log_hints has been added

You got the wal_level and wal_log_hints strings backwards:

Oops. Thanks for double-checking.
--
Michael