duplicate #define

Started by Mark Dilgerabout 11 years ago2 messages

hornschnorter@gmail.com

about 11 years ago

1 attachment(s)

In commit 2c03216d831160bedd72d45f712601b6f7d03f1c, the
following define occurs twice in src/include/access/xlogrecord.h:

#define SizeOfXLogRecordDataHeaderLong (sizeof(uint8) + sizeof(uint32))

It is no big deal, as the definitions don't contradict each other. We
could probably live with just one, though.

Patch attached

Mark Dilger

Attachments:

xlogrecord.difftext/plain; charset=US-ASCII; name=xlogrecord.diffDownload

diff --git a/src/include/access/xlogrecord.h b/src/include/access/xlogrecord.h
index 11ddfac..fbfad5f 100644
--- a/src/include/access/xlogrecord.h
+++ b/src/include/access/xlogrecord.h
@@ -174,7 +174,4 @@ typedef struct XLogRecordDataHeaderLong
 #define XLR_BLOCK_ID_DATA_SHORT		255
 #define XLR_BLOCK_ID_DATA_LONG		254
 
-#define SizeOfXLogRecordDataHeaderLong (sizeof(uint8) + sizeof(uint32))
-
-
 #endif   /* XLOGRECORD_H */

Heikki Linnakangas

hlinnakangas@vmware.com

about 11 years ago

In reply to: Mark Dilger (#1)

Re: duplicate #define

On 12/13/2014 04:45 PM, Mark Dilger wrote:

In commit 2c03216d831160bedd72d45f712601b6f7d03f1c, the
following define occurs twice in src/include/access/xlogrecord.h:

#define SizeOfXLogRecordDataHeaderLong (sizeof(uint8) + sizeof(uint32))

It is no big deal, as the definitions don't contradict each other. We
could probably live with just one, though.

Patch attached

Thanks, fixed!

- Heikki

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers