postgres messages error

Started by Martín Marquésabout 11 years ago5 messages
#1Martín Marqués
martin@2ndquadrant.com

Hi there,

I was doing some translation on postgres.po and found a string which
looks mistaken.

#: libpq/auth.c:1593
#, fuzzy, c-format
msgid "could not to look up local user ID %ld: %s"

It looks like there is an extra *to* there , so the string should be:

"could not look up local user ID %ld: %s"

Cheers,

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Adam Brightwell
adam.brightwell@crunchydatasolutions.com
In reply to: Martín Marqués (#1)
1 attachment(s)
Re: postgres messages error

Martin,

#: libpq/auth.c:1593

#, fuzzy, c-format
msgid "could not to look up local user ID %ld: %s"

It looks like there is an extra *to* there , so the string should be:

"could not look up local user ID %ld: %s"

I think you are right. FWIW, I have attached a patch that fixes it for
consideration if others concur.

-Adam

--
Adam Brightwell - adam.brightwell@crunchydatasolutions.com
Database Engineer - www.crunchydatasolutions.com

Attachments:

auth_c-error-message-fix.patchtext/x-patch; charset=US-ASCII; name=auth_c-error-message-fix.patchDownload
diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c
new file mode 100644
index 9ad99ce..2b2dbb3
*** a/src/backend/libpq/auth.c
--- b/src/backend/libpq/auth.c
*************** auth_peer(hbaPort *port)
*** 1590,1596 ****
  	if (!pw)
  	{
  		ereport(LOG,
! 				(errmsg("could not to look up local user ID %ld: %s",
  		   (long) uid, errno ? strerror(errno) : _("user does not exist"))));
  		return STATUS_ERROR;
  	}
--- 1590,1596 ----
  	if (!pw)
  	{
  		ereport(LOG,
! 				(errmsg("could not look up local user ID %ld: %s",
  		   (long) uid, errno ? strerror(errno) : _("user does not exist"))));
  		return STATUS_ERROR;
  	}
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Adam Brightwell (#2)
Re: postgres messages error

Adam Brightwell <adam.brightwell@crunchydatasolutions.com> writes:

Martin,
#: libpq/auth.c:1593

#, fuzzy, c-format
msgid "could not to look up local user ID %ld: %s"

It looks like there is an extra *to* there , so the string should be:

"could not look up local user ID %ld: %s"

I think you are right. FWIW, I have attached a patch that fixes it for
consideration if others concur.

I agree, that good English is not. Will commit.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Tom Lane (#3)
Re: postgres messages error

Tom Lane wrote:

Adam Brightwell <adam.brightwell@crunchydatasolutions.com> writes:

Martin,
#: libpq/auth.c:1593

#, fuzzy, c-format
msgid "could not to look up local user ID %ld: %s"

It looks like there is an extra *to* there , so the string should be:

"could not look up local user ID %ld: %s"

I think you are right. FWIW, I have attached a patch that fixes it for
consideration if others concur.

I agree, that good English is not. Will commit.

A quick grep reveals also

initdb.po:msgid "%s: could not to allocate SIDs: error code %lu\n"

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#4)
Re: postgres messages error

Alvaro Herrera <alvherre@2ndquadrant.com> writes:

A quick grep reveals also
initdb.po:msgid "%s: could not to allocate SIDs: error code %lu\n"

Good catch, I'll get that one too.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers