Typo in a comment in set_rel_size()

Started by Amit Langotealmost 11 years ago3 messages
#1Amit Langote
Langote_Amit_f8@lab.ntt.co.jp
1 attachment(s)

Hi,

Attached fixes what I suppose is a typo:

* so set up a single dummy path for it. Here we only check this for
* regular baserels; if it's an otherrel, CE was already checked in
- * set_append_rel_pathlist().
+ * set_append_rel_size().
*

Thanks,
Amit

Attachments:

set_rel_size-comment-typo.patchtext/x-diff; name=set_rel_size-comment-typo.patchDownload
diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c
index 58d78e6..c4b0c79 100644
--- a/src/backend/optimizer/path/allpaths.c
+++ b/src/backend/optimizer/path/allpaths.c
@@ -241,7 +241,7 @@ set_rel_size(PlannerInfo *root, RelOptInfo *rel,
 		 * We proved we don't need to scan the rel via constraint exclusion,
 		 * so set up a single dummy path for it.  Here we only check this for
 		 * regular baserels; if it's an otherrel, CE was already checked in
-		 * set_append_rel_pathlist().
+		 * set_append_rel_size().
 		 *
 		 * In this case, we go ahead and set up the relation's path right away
 		 * instead of leaving it for set_rel_pathlist to do.  This is because
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Amit Langote (#1)
Re: Typo in a comment in set_rel_size()

Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:

Attached fixes what I suppose is a typo:

* so set up a single dummy path for it. Here we only check this for
* regular baserels; if it's an otherrel, CE was already checked in
- * set_append_rel_pathlist().
+ * set_append_rel_size().
*

It's not a typo; the comment was correct when written. But I evidently
missed updating it when set_append_rel_pathlist() got split into two
functions. Applied, thanks for noticing!

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Amit Langote
Langote_Amit_f8@lab.ntt.co.jp
In reply to: Tom Lane (#2)
Re: Typo in a comment in set_rel_size()

On 2015-04-25 AM 04:20, Tom Lane wrote: *

It's not a typo; the comment was correct when written. But I evidently
missed updating it when set_append_rel_pathlist() got split into two
functions. Applied, thanks for noticing!

Ah, thanks!

Amit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers