Fix token exceeding NAMELEN
Trying to build HEAD and ran into this issue building the docs:
openjade:logicaldecoding.sgml:575:62:Q: length of name token must
not exceed NAMELEN (44)
openjade:replication-origins.sgml:87:67:Q: length of name token must
not exceed NAMELEN (44)
I've tried playing with the flags we (you) pass to openjade, but
couldn't make it override NAMELEN.
So, I've attached a patch that'll fix it.
Attachments:
0001-Fix-token-exceeding-NAMELEN.patchtext/x-diff; charset=utf-8Download
From 231b317e2eda1f63ff3f5485105c4e8ac1f36146 Mon Sep 17 00:00:00 2001
From: "Aaron W. Swenson" <aaron.w.swenson@gmail.com>
Date: Wed, 13 May 2015 15:42:46 -0400
Subject: [PATCH] Fix token exceeding NAMELEN
---
doc/src/sgml/logicaldecoding.sgml | 2 +-
doc/src/sgml/replication-origins.sgml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml
index f817af3..00f6eee 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+++ b/doc/src/sgml/logicaldecoding.sgml
@@ -572,7 +572,7 @@ typedef void (*LogicalDecodeChangeCB) (
</note>
</sect3>
- <sect3 id="logicaldecoding-output-plugin-filter-by-origin">
+ <sect3 id="logicaldecoding-output-plugin-filter-origin">
<title>Origin Filter Callback</title>
<para>
diff --git a/doc/src/sgml/replication-origins.sgml b/doc/src/sgml/replication-origins.sgml
index 5a4b4cb..40fcc6d 100644
--- a/doc/src/sgml/replication-origins.sgml
+++ b/doc/src/sgml/replication-origins.sgml
@@ -84,7 +84,7 @@
generated by the session is tagged with the replication origin of the
generating session. This allows to treat them differently in the output
plugin, e.g. ignoring all but locally originating rows. Additionally
- the <link linkend="logicaldecoding-output-plugin-filter-by-origin">
+ the <link linkend="logicaldecoding-output-plugin-filter-origin">
<function>filter_by_origin_cb</function></link> callback can be used
to filter the logical decoding change stream based on the
source. While less flexible, filtering via that callback is
--
2.3.6
"Aaron W. Swenson" <titanofold@gentoo.org> writes:
Trying to build HEAD and ran into this issue building the docs:
openjade:logicaldecoding.sgml:575:62:Q: length of name token must
not exceed NAMELEN (44)
openjade:replication-origins.sgml:87:67:Q: length of name token must
not exceed NAMELEN (44)
Hmm ... that's odd. I don't see any such failure here, and the buildfarm
members that build the docs aren't complaining either. What version of
openjade are you using exactly?
So, I've attached a patch that'll fix it.
I have no particular objection to the patch as stated, but I'm just
wondering if this is the tip of a tool compatibility iceberg we were
not previously aware of.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 13 May 2015 at 17:55, Tom Lane <tgl@sss.pgh.pa.us> wrote:
"Aaron W. Swenson" <titanofold@gentoo.org> writes:
Trying to build HEAD and ran into this issue building the docs:
openjade:logicaldecoding.sgml:575:62:Q: length of name token must
not exceed NAMELEN (44)
openjade:replication-origins.sgml:87:67:Q: length of name token must
not exceed NAMELEN (44)Hmm ... that's odd. I don't see any such failure here, and the buildfarm
members that build the docs aren't complaining either. What version of
openjade are you using exactly?So, I've attached a patch that'll fix it.
I have no particular objection to the patch as stated, but I'm just
wondering if this is the tip of a tool compatibility iceberg we were
not previously aware of.
I recall us hitting this with Slony documentation. The NAMELEN limit
lay in the SGML/DocBook configuration that was configured at the
distribution level, so that it differed (crucially) betwen Debian and
Red Hat.
Red Hat used to have a lower name length limit, and while overriding
it was technically possible, it required modifying configuration that
the distribution thought was owned by one of the SGML packages,
and hence the modification seemed pretty inadvisable.
I thought that this restriction was alleviated years ago, so I'm a bit
surprised to see this come up in 2015. (Or perhaps Gentoo hasn't
yet opened up some limits??? :-) )
--
When confronted by a difficult problem, solve it by reducing it to the
question, "How would the Lone Ranger handle this?"
On 2015-05-13 18:16, Christopher Browne wrote:
On 13 May 2015 at 17:55, Tom Lane <tgl@sss.pgh.pa.us> wrote:
"Aaron W. Swenson" <titanofold@gentoo.org> writes:
Trying to build HEAD and ran into this issue building the docs:
openjade:logicaldecoding.sgml:575:62:Q: length of name token must
not exceed NAMELEN (44)
openjade:replication-origins.sgml:87:67:Q: length of name token must
not exceed NAMELEN (44)Hmm ... that's odd. I don't see any such failure here, and the buildfarm
members that build the docs aren't complaining either. What version of
openjade are you using exactly?So, I've attached a patch that'll fix it.
I have no particular objection to the patch as stated, but I'm just
wondering if this is the tip of a tool compatibility iceberg we were
not previously aware of.I recall us hitting this with Slony documentation. The NAMELEN limit
lay in the SGML/DocBook configuration that was configured at the
distribution level, so that it differed (crucially) betwen Debian and
Red Hat.Red Hat used to have a lower name length limit, and while overriding
it was technically possible, it required modifying configuration that
the distribution thought was owned by one of the SGML packages,
and hence the modification seemed pretty inadvisable.I thought that this restriction was alleviated years ago, so I'm a bit
surprised to see this come up in 2015. (Or perhaps Gentoo hasn't
yet opened up some limits??? :-) )
The restriction is alleviated (patched) by some distributions, and
Gentoo isn't among those.
It has been almost 4 years (the most recent Google has found) since the
last time this happened with PostgreSQL's docs.
/messages/by-id/BANLkTiktW6SRDygVfJRB4q+7dvWoQCC1Yg@mail.gmail.com
"Aaron W. Swenson" <titanofold@gentoo.org> writes:
On 2015-05-13 18:16, Christopher Browne wrote:
I thought that this restriction was alleviated years ago, so I'm a bit
surprised to see this come up in 2015. (Or perhaps Gentoo hasn't
yet opened up some limits??? :-) )
The restriction is alleviated (patched) by some distributions, and
Gentoo isn't among those.
It has been almost 4 years (the most recent Google has found) since the
last time this happened with PostgreSQL's docs.
/messages/by-id/BANLkTiktW6SRDygVfJRB4q+7dvWoQCC1Yg@mail.gmail.com
Ah, so we have hit it before and forgotten. Might as well stick to the
previous decision then. Patch applied, thanks!
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers