Missing "-i / --ignore-version" in pg_dump help
Hi all,
There are some reason to "-i, --ignore-version" option doesn't appear in
pg_dump help?
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
Show quoted text
Timbira: http://www.timbira.com.br
Blog: http://fabriziomello.github.io
Linkedin: http://br.linkedin.com/in/fabriziomello
Twitter: http://twitter.com/fabriziomello
Github: http://github.com/fabriziomello
On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
Hi all,
There are some reason to "-i, --ignore-version" option doesn't appear in
pg_dump help?
Because it's obsolete option, I think.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, May 22, 2015 at 9:20 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:Hi all,
There are some reason to "-i, --ignore-version" option doesn't appear in
pg_dump help?Because it's obsolete option, I think.
You're correct... looking at the source code:
421 case 'i':
422 /* ignored, deprecated option */
423 break;
Thanks!
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
Show quoted text
Timbira: http://www.timbira.com.br
Blog: http://fabriziomello.github.io
Linkedin: http://br.linkedin.com/in/fabriziomello
Twitter: http://twitter.com/fabriziomello
Github: http://github.com/fabriziomello
Fujii Masao <masao.fujii@gmail.com> writes:
On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:There are some reason to "-i, --ignore-version" option doesn't appear in
pg_dump help?
Because it's obsolete option, I think.
Yeah, see commit c22ed3d523782c43836c163c16fa5a7bb3912826.
Considering we shipped that in 8.4, maybe it's time to remove all
trace of those switches. We'd still have to wait a couple releases
before it'd be safe to use -i for something else, but it'd be a start.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, May 22, 2015 at 11:01 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Fujii Masao <masao.fujii@gmail.com> writes:
On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:There are some reason to "-i, --ignore-version" option doesn't appear in
pg_dump help?Because it's obsolete option, I think.
Yeah, see commit c22ed3d523782c43836c163c16fa5a7bb3912826.
Considering we shipped that in 8.4, maybe it's time to remove all
trace of those switches. We'd still have to wait a couple releases
before it'd be safe to use -i for something else, but it'd be a start.
+1
Barring any objection, I will apply the attached patch and
remove that obsolete option..
Regards,
--
Fujii Masao
Attachments:
remove-i-option-from-pgdump.patchapplication/x-patch; name=remove-i-option-from-pgdump.patchDownload+6-50
On Wed, Jun 3, 2015 at 1:53 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
On Fri, May 22, 2015 at 11:01 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Fujii Masao <masao.fujii@gmail.com> writes:
On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:There are some reason to "-i, --ignore-version" option doesn't appear in
pg_dump help?Because it's obsolete option, I think.
Yeah, see commit c22ed3d523782c43836c163c16fa5a7bb3912826.
Considering we shipped that in 8.4, maybe it's time to remove all
trace of those switches. We'd still have to wait a couple releases
before it'd be safe to use -i for something else, but it'd be a start.+1
Barring any objection, I will apply the attached patch and
remove that obsolete option..
Applied.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers