Missing tab-complete for PASSWORD word in CREATE ROLE syntax

Started by Jeevan Chalkeover 10 years ago2 messages

Jeevan Chalke

jeevan.chalke@enterprisedb.com

over 10 years ago

1 attachment(s)

Hi,

I have observed that we are not tab-completing word PASSWORD in the
following
syntaxes:

1.
CREATE|ALTER ROLE|USER rolname

2.
CREATE|ALTER ROLE|USER rolname WITH

PASSWORD is used many times and should be in the tab-complete list.

Was there any reason we have deliberately kept this out?
If yes, please ignore my patch.
Attached patch to add those missing tab-completes.

Thanks

--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Attachments:

tab_complete_password_in_create_alter_role_v1.patchapplication/x-download; name=tab_complete_password_in_create_alter_role_v1.patchDownload

diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index b9f5acc..b5cd7cd 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -1220,9 +1220,9 @@ psql_completion(const char *text, int start, int end)
 		{"BYPASSRLS", "CONNECTION LIMIT", "CREATEDB", "CREATEROLE",
 			"CREATEUSER", "ENCRYPTED", "INHERIT", "LOGIN", "NOBYPASSRLS",
 			"NOCREATEDB", "NOCREATEROLE", "NOCREATEUSER", "NOINHERIT",
-			"NOLOGIN", "NOREPLICATION", "NOSUPERUSER", "RENAME TO",
+			"NOLOGIN", "NOREPLICATION", "NOSUPERUSER", "PASSWORD", "RENAME TO",
 			"REPLICATION", "RESET", "SET", "SUPERUSER", "UNENCRYPTED",
-		"VALID UNTIL", "WITH", NULL};
+			"VALID UNTIL", "WITH", NULL};
 
 		COMPLETE_WITH_LIST(list_ALTERUSER);
 	}
@@ -1238,9 +1238,9 @@ psql_completion(const char *text, int start, int end)
 		{"BYPASSRLS", "CONNECTION LIMIT", "CREATEDB", "CREATEROLE",
 			"CREATEUSER", "ENCRYPTED", "INHERIT", "LOGIN", "NOBYPASSRLS",
 			"NOCREATEDB", "NOCREATEROLE", "NOCREATEUSER", "NOINHERIT",
-			"NOLOGIN", "NOREPLICATION", "NOSUPERUSER", "RENAME TO",
+			"NOLOGIN", "NOREPLICATION", "NOSUPERUSER", "PASSWORD", "RENAME TO",
 			"REPLICATION", "RESET", "SET", "SUPERUSER", "UNENCRYPTED",
-		"VALID UNTIL", NULL};
+			"VALID UNTIL", NULL};
 
 		COMPLETE_WITH_LIST(list_ALTERUSER_WITH);
 	}
@@ -2584,8 +2584,9 @@ psql_completion(const char *text, int start, int end)
 		{"ADMIN", "BYPASSRLS", "CONNECTION LIMIT", "CREATEDB", "CREATEROLE",
 			"CREATEUSER", "ENCRYPTED", "IN", "INHERIT", "LOGIN", "NOBYPASSRLS",
 			"NOCREATEDB", "NOCREATEROLE", "NOCREATEUSER", "NOINHERIT",
-			"NOLOGIN", "NOREPLICATION", "NOSUPERUSER", "REPLICATION", "ROLE",
-		"SUPERUSER", "SYSID", "UNENCRYPTED", "VALID UNTIL", "WITH", NULL};
+			"NOLOGIN", "NOREPLICATION", "NOSUPERUSER", "PASSWORD",
+			"REPLICATION", "ROLE", "SUPERUSER", "SYSID", "UNENCRYPTED",
+			"VALID UNTIL", "WITH", NULL};
 
 		COMPLETE_WITH_LIST(list_CREATEROLE);
 	}
@@ -2602,8 +2603,9 @@ psql_completion(const char *text, int start, int end)
 		{"ADMIN", "BYPASSRLS", "CONNECTION LIMIT", "CREATEDB", "CREATEROLE",
 			"CREATEUSER", "ENCRYPTED", "IN", "INHERIT", "LOGIN", "NOBYPASSRLS",
 			"NOCREATEDB", "NOCREATEROLE", "NOCREATEUSER", "NOINHERIT",
-			"NOLOGIN", "NOREPLICATION", "NOSUPERUSER", "REPLICATION", "ROLE",
-		"SUPERUSER", "SYSID", "UNENCRYPTED", "VALID UNTIL", NULL};
+			"NOLOGIN", "NOREPLICATION", "NOSUPERUSER", "PASSWORD",
+			"REPLICATION", "ROLE", "SUPERUSER", "SYSID", "UNENCRYPTED",
+			"VALID UNTIL", NULL};
 
 		COMPLETE_WITH_LIST(list_CREATEROLE_WITH);
 	}

Robert Haas

robertmhaas@gmail.com

over 10 years ago

In reply to: Jeevan Chalke (#1)

Re: Missing tab-complete for PASSWORD word in CREATE ROLE syntax

On Fri, Jun 19, 2015 at 5:52 AM, Jeevan Chalke
<jeevan.chalke@enterprisedb.com> wrote:

I have observed that we are not tab-completing word PASSWORD in the
following
syntaxes:

1.
CREATE|ALTER ROLE|USER rolname

2.
CREATE|ALTER ROLE|USER rolname WITH

PASSWORD is used many times and should be in the tab-complete list.

Was there any reason we have deliberately kept this out?
If yes, please ignore my patch.
Attached patch to add those missing tab-completes.

Thanks, committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers