pgsql: Change TAP test framework to not rely on having a chmod executab
Change TAP test framework to not rely on having a chmod executable.
This might not work at all on Windows, and is not ever efficient.
Michael Paquier
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/ca3f43aa48a83013ea50aeee7cd193a5859c4587
Modified Files
--------------
src/test/ssl/ServerSetup.pm | 16 +++++++++++++++-
src/test/ssl/t/001_ssltests.pl | 2 +-
2 files changed, 16 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On 6/19/15 10:52 AM, Robert Haas wrote:
Change TAP test framework to not rely on having a chmod executable.
This might not work at all on Windows, and is not ever efficient.
Michael Paquier
I came across this on an unrelated mission and noticed it was
unnecessarily complicated. How about this patch instead?
Attachments:
0001-Simplify-Perl-chmod-calls.patchtext/x-diff; name=0001-Simplify-Perl-chmod-calls.patchDownload+1-16
On Tue, Aug 25, 2015 at 11:02 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
On 6/19/15 10:52 AM, Robert Haas wrote:
Change TAP test framework to not rely on having a chmod executable.
This might not work at all on Windows, and is not ever efficient.
Michael Paquier
I came across this on an unrelated mission and noticed it was
unnecessarily complicated. How about this patch instead?
I didn't know this one... Looking at the docs this would visibly work
at least down to 5.8.8, the docs saying that a list of files can be
passed to chmod:
http://perldoc.perl.org/5.8.8/functions/chmod.html
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers