A couple of newlines missing in pg_rewind log entries

On Tue, Jun 23, 2015 at 1:39 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

Hi all,

Some grepping is showing up that a couple of newlines are missing in
pg_rewind, leading to unreadable log entries:
libpq_fetch.c: pg_log(PG_DEBUG, "getting file chunks");
logging.c: pg_log(PG_PROGRESS, "%*s/%s kB (%d%%) copied",
filemap.c: pg_fatal("could not stat file \"%s\": %s",

Attached is a patch to fix them.

Please ignore that. It has been fixed yesterday with e98d635.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On 06/23/2015 07:39 AM, Michael Paquier wrote:

Hi all,

Some grepping is showing up that a couple of newlines are missing in
pg_rewind, leading to unreadable log entries:
libpq_fetch.c: pg_log(PG_DEBUG, "getting file chunks");

Fixed.

logging.c: pg_log(PG_PROGRESS, "%*s/%s kB (%d%%) copied",

This one was on purpose; note the printf("\r") after that line. That's
supposed to be a progress indicator that is updated on the single line.

filemap.c: pg_fatal("could not stat file \"%s\": %s",

Peter fixed this already.

- Heikki

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers