Apr 2019

1 commit
GSSAPI encryption support
3 Apr 2019Stephen Frostmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #1711 of 10 reviewers saw the final version

The complete diff matches #171 across all 35 files, including context lines; only index-hash abbreviation lengths and the mail footer differ. Although Stephen Frost sent the patch, its header and the commit credit Robbie Harwood, with Frost's read/write changes.

  • Michael Paquiersaw an earlier versionLLM analysis, 99% sureReviewed protocol design, compatibility and buffering, supplied Windows fixes in #73 and #74, and verified the crash fix in #88, before subsequent negotiation and I/O redesigns.
  • Andres Freundsaw an earlier versionLLM analysis, 99% sureIdentified buffer leaks, header/GUC problems and misplaced encryption logic in #13, then reviewed connection-layer structure in #152 before the bounded-buffer rewrite.
  • David Steelesaw an earlier versionLLM analysis, 99% sureTested successive versions, requested complete GSS error retrieval and clearer documentation in #69, and reported successful testing in #92 before later architectural changes.
  • Jeff Janessaw an earlier versionLLM analysis, 84% sureReported a reproducible synchronization failure with patched client and server in the original implementation's v2 discussion #36, before that implementation was replaced.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 91% sureIdentified writev portability problems in #77, addressed by replacing those calls in #81, well before the final transport rewrite.
  • Tom Lanesaw an earlier versionLLM analysis, 100% sureRequested connection-local state instead of a USERSET GUC in #79 and identified exposed startup parameters in #101, prompting the later pre-startup encryption handshake.
  • Thomas Munrosaw an earlier versionLLM analysis, 97% sureIdentified the exact Windows source-path typo and malformed SGML in #118, fixed in #120 before subsequent substantial I/O changes.
  • Nico Williamssaw an earlier versionLLM analysis, 94% sureHis GSS error-checking and short-read review was incorporated in #130 and confirmed in #132, preceding the bounded-buffer rewrite.
  • Peter Eisentrautsaw an earlier versionLLM analysis, 90% sureRequested tests and clearer encryption naming in #159 and #167; the final revision adopted that naming but also changed pg_stat_get_activity NULL handling beyond purely editorial changes.
  • Stephen Frostsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Robbie Harwood1
with changes to the read/write functions by me.1
Reviewer
Stephen Frostcommitter1
Committer
Stephen Frost1