Outdated documentation for PageHeaderData

Started by Julien Rouhaudover 10 years ago3 messages
#1Julien Rouhaud
julien.rouhaud@dalibo.com
1 attachment(s)

Hi,

I just noticed that part of storage.sgml was not updated when 9.3
introduced checksum (and removed pd_tli from PageHeaderData).

Here's a simple patch to fix that.

Regards.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org

Attachments:

storage_sgml_pageheaderdata.difftext/x-patch; name=storage_sgml_pageheaderdata.diffDownload
diff --git a/doc/src/sgml/storage.sgml b/doc/src/sgml/storage.sgml
index e5b7b4b..9934efd 100644
--- a/doc/src/sgml/storage.sgml
+++ b/doc/src/sgml/storage.sgml
@@ -759,9 +759,10 @@ data. Empty in ordinary tables.</entry>
 
   The first 24 bytes of each page consists of a page header
   (PageHeaderData). Its format is detailed in <xref
-  linkend="pageheaderdata-table">. The first two fields track the most
-  recent WAL entry related to this page. Next is a 2-byte field
-  containing flag bits. This is followed by three 2-byte integer fields
+  linkend="pageheaderdata-table">. The first field tracks the most recent WAL
+  entry related to this page. The next field stores the checksum for this page.
+  Next is a 2-byte field containing flag bits. This is followed by three 2-byte
+  integer fields
   (<structfield>pd_lower</structfield>, <structfield>pd_upper</structfield>,
   and <structfield>pd_special</structfield>). These contain byte offsets
   from the page start to the start
#2Michael Paquier
michael.paquier@gmail.com
In reply to: Julien Rouhaud (#1)
Re: Outdated documentation for PageHeaderData

On Sun, Sep 6, 2015 at 5:11 AM, Julien Rouhaud <julien.rouhaud@dalibo.com>
wrote:

I just noticed that part of storage.sgml was not updated when 9.3
introduced checksum (and removed pd_tli from PageHeaderData).

Yep, see that as well:
/messages/by-id/CAB7nPqSV1kR6FqWf2rOVter5cXAW8oTH+DKZjwP4Meji5do5wg@mail.gmail.com
I just fell out of committer's laser radar I guess.
--
Michael

#3Julien Rouhaud
julien.rouhaud@dalibo.com
In reply to: Michael Paquier (#2)
Re: Outdated documentation for PageHeaderData

On 06/09/2015 01:39, Michael Paquier wrote:

On Sun, Sep 6, 2015 at 5:11 AM, Julien Rouhaud
<julien.rouhaud@dalibo.com <mailto:julien.rouhaud@dalibo.com>> wrote:

I just noticed that part of storage.sgml was not updated when 9.3
introduced checksum (and removed pd_tli from PageHeaderData).

Yep, see that as well:
/messages/by-id/CAB7nPqSV1kR6FqWf2rOVter5cXAW8oTH+DKZjwP4Meji5do5wg@mail.gmail.com
I just fell out of committer's laser radar I guess.

Oh, I didn't see that thread. Sounds like I should subscribe on -docs.

--
Julien Rouhaud
http://dalibo.com - http://dalibo.org

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers