pg_resetxlog sentences

Started by Euler Taveiraover 10 years ago7 messages

Euler Taveira

euler@timbira.com.br

over 10 years ago

1 attachment(s)

Hi,

While updating translations, I came across those almost similar sentences.

pg_controldata.c

273 printf(_("Latest checkpoint's oldestCommitTs: %u\n"),
274 ControlFile.checkPointCopy.oldestCommitTs);

pg_resetxlog.c

668 printf(_("Latest checkpoint's oldest CommitTs: %u\n"),
669 ControlFile.checkPointCopy.oldestCommitTs);
670 printf(_("Latest checkpoint's newest CommitTs: %u\n"),
671 ControlFile.checkPointCopy.newestCommitTs);

To be consistent, let's change pg_resetxlog to mimic pg_controldata
sentence. Patch is attached. It is new in 9.5 so backpatch is needed.

--
Euler Taveira Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachments:

0001-Use-the-same-word-as-pg_controldata.patchtext/x-patch; name=0001-Use-the-same-word-as-pg_controldata.patchDownload

>From cc8da654ab363366860de6c114bfc9a28561978a Mon Sep 17 00:00:00 2001
From: Euler Taveira <euler@timbira.com.br>
Date: Tue, 15 Sep 2015 22:45:38 -0300
Subject: [PATCH] Use the same word as pg_controldata.

---
 src/bin/pg_resetxlog/pg_resetxlog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
index b771a63..a1a9e14 100644
--- a/src/bin/pg_resetxlog/pg_resetxlog.c
+++ b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -665,9 +665,9 @@ PrintControlValues(bool guessed)
 		   ControlFile.checkPointCopy.oldestMulti);
 	printf(_("Latest checkpoint's oldestMulti's DB: %u\n"),
 		   ControlFile.checkPointCopy.oldestMultiDB);
-	printf(_("Latest checkpoint's oldest CommitTs:  %u\n"),
+	printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
 		   ControlFile.checkPointCopy.oldestCommitTs);
-	printf(_("Latest checkpoint's newest CommitTs:  %u\n"),
+	printf(_("Latest checkpoint's newestCommitTs:   %u\n"),
 		   ControlFile.checkPointCopy.newestCommitTs);
 	printf(_("Maximum data alignment:               %u\n"),
 		   ControlFile.maxAlign);
-- 
2.1.4

Robert Haas

robertmhaas@gmail.com

over 10 years ago

In reply to: Euler Taveira (#1)

Re: pg_resetxlog sentences

On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler@timbira.com.br> wrote:

While updating translations, I came across those almost similar sentences.

pg_controldata.c

273 printf(_("Latest checkpoint's oldestCommitTs: %u\n"),
274 ControlFile.checkPointCopy.oldestCommitTs);

pg_resetxlog.c

668 printf(_("Latest checkpoint's oldest CommitTs: %u\n"),
669 ControlFile.checkPointCopy.oldestCommitTs);
670 printf(_("Latest checkpoint's newest CommitTs: %u\n"),
671 ControlFile.checkPointCopy.newestCommitTs);

To be consistent, let's change pg_resetxlog to mimic pg_controldata
sentence. Patch is attached. It is new in 9.5 so backpatch is needed.

Seems like a good idea to me. Anyone disagree?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Alvaro Herrera

alvherre@2ndquadrant.com

over 10 years ago

In reply to: Robert Haas (#2)

Re: pg_resetxlog sentences

Robert Haas wrote:

On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler@timbira.com.br> wrote:

While updating translations, I came across those almost similar sentences.

pg_controldata.c

273 printf(_("Latest checkpoint's oldestCommitTs: %u\n"),
274 ControlFile.checkPointCopy.oldestCommitTs);

pg_resetxlog.c

668 printf(_("Latest checkpoint's oldest CommitTs: %u\n"),
669 ControlFile.checkPointCopy.oldestCommitTs);
670 printf(_("Latest checkpoint's newest CommitTs: %u\n"),
671 ControlFile.checkPointCopy.newestCommitTs);

To be consistent, let's change pg_resetxlog to mimic pg_controldata
sentence. Patch is attached. It is new in 9.5 so backpatch is needed.

Seems like a good idea to me. Anyone disagree?

OK with me.

--
ï¿½lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Fujii Masao

masao.fujii@gmail.com

over 10 years ago

In reply to: Alvaro Herrera (#3)

Re: pg_resetxlog sentences

On Thu, Sep 17, 2015 at 5:00 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:

Robert Haas wrote:

On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler@timbira.com.br> wrote:

While updating translations, I came across those almost similar sentences.

pg_controldata.c

273 printf(_("Latest checkpoint's oldestCommitTs: %u\n"),
274 ControlFile.checkPointCopy.oldestCommitTs);

pg_resetxlog.c

668 printf(_("Latest checkpoint's oldest CommitTs: %u\n"),
669 ControlFile.checkPointCopy.oldestCommitTs);
670 printf(_("Latest checkpoint's newest CommitTs: %u\n"),
671 ControlFile.checkPointCopy.newestCommitTs);

To be consistent, let's change pg_resetxlog to mimic pg_controldata
sentence. Patch is attached. It is new in 9.5 so backpatch is needed.

Seems like a good idea to me. Anyone disagree?

OK with me.

One relevant question is; why doesn't pg_controldata report newestCommitTs?

Regards,

--
Fujii Masao

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Alvaro Herrera

alvherre@2ndquadrant.com

over 10 years ago

In reply to: Fujii Masao (#4)

Re: pg_resetxlog sentences

Fujii Masao wrote:

On Thu, Sep 17, 2015 at 5:00 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:

Robert Haas wrote:

On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler@timbira.com.br> wrote:

While updating translations, I came across those almost similar sentences.

pg_controldata.c

273 printf(_("Latest checkpoint's oldestCommitTs: %u\n"),
274 ControlFile.checkPointCopy.oldestCommitTs);

pg_resetxlog.c

668 printf(_("Latest checkpoint's oldest CommitTs: %u\n"),
669 ControlFile.checkPointCopy.oldestCommitTs);
670 printf(_("Latest checkpoint's newest CommitTs: %u\n"),
671 ControlFile.checkPointCopy.newestCommitTs);

To be consistent, let's change pg_resetxlog to mimic pg_controldata
sentence. Patch is attached. It is new in 9.5 so backpatch is needed.

Seems like a good idea to me. Anyone disagree?

OK with me.

+1

One relevant question is; why doesn't pg_controldata report newestCommitTs?

Most likely an oversight. As I recall, we added newestCommitTs in a
later version of the patch; we probably patched pg_controldata earlier
and then failed to realize that we needed to add the new field.

--
ï¿½lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Euler Taveira

euler@timbira.com.br

over 10 years ago

In reply to: Fujii Masao (#4)

1 attachment(s)

Re: pg_resetxlog sentences

On 17-09-2015 00:25, Fujii Masao wrote:

One relevant question is; why doesn't pg_controldata report newestCommitTs?

I thought about it while looking at the code but forgot to ask. AFAICS
it is an oversight. See attached patch.

--
Euler Taveira Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachments:

0001-Standardize-sentences.patchtext/x-patch; name=0001-Standardize-sentences.patchDownload

>From 5716c69d7287d97c6eacb13c736c939d0e9223e4 Mon Sep 17 00:00:00 2001
From: Euler Taveira <euler@timbira.com.br>
Date: Thu, 17 Sep 2015 13:48:25 -0300
Subject: [PATCH] Standardize sentences.

Also, add newest CommitTs to pg_controldata. Oversight spotted by Fujii
Masao.
---
 src/bin/pg_controldata/pg_controldata.c | 2 ++
 src/bin/pg_resetxlog/pg_resetxlog.c     | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/bin/pg_controldata/pg_controldata.c b/src/bin/pg_controldata/pg_controldata.c
index 704f72d..32e1d81 100644
--- a/src/bin/pg_controldata/pg_controldata.c
+++ b/src/bin/pg_controldata/pg_controldata.c
@@ -273,6 +273,8 @@ main(int argc, char *argv[])
 		   ControlFile.checkPointCopy.oldestMultiDB);
 	printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
 		   ControlFile.checkPointCopy.oldestCommitTs);
+	printf(_("Latest checkpoint's newestCommitTs:   %u\n"),
+		   ControlFile.checkPointCopy.newestCommitTs);
 	printf(_("Time of latest checkpoint:            %s\n"),
 		   ckpttime_str);
 	printf(_("Fake LSN counter for unlogged rels:   %X/%X\n"),
diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
index c8c1ac3..d7ac2ba 100644
--- a/src/bin/pg_resetxlog/pg_resetxlog.c
+++ b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -665,9 +665,9 @@ PrintControlValues(bool guessed)
 		   ControlFile.checkPointCopy.oldestMulti);
 	printf(_("Latest checkpoint's oldestMulti's DB: %u\n"),
 		   ControlFile.checkPointCopy.oldestMultiDB);
-	printf(_("Latest checkpoint's oldest CommitTs:  %u\n"),
+	printf(_("Latest checkpoint's oldestCommitTs:   %u\n"),
 		   ControlFile.checkPointCopy.oldestCommitTs);
-	printf(_("Latest checkpoint's newest CommitTs:  %u\n"),
+	printf(_("Latest checkpoint's newestCommitTs:   %u\n"),
 		   ControlFile.checkPointCopy.newestCommitTs);
 	printf(_("Maximum data alignment:               %u\n"),
 		   ControlFile.maxAlign);
-- 
2.1.4

Fujii Masao

masao.fujii@gmail.com

over 10 years ago

In reply to: Euler Taveira (#6)

Re: pg_resetxlog sentences

On Fri, Sep 18, 2015 at 1:58 AM, Euler Taveira <euler@timbira.com.br> wrote:

On 17-09-2015 00:25, Fujii Masao wrote:

One relevant question is; why doesn't pg_controldata report
newestCommitTs?

I thought about it while looking at the code but forgot to ask. AFAICS it is
an oversight. See attached patch.

Applied. Thanks!

Regards,

--
Fujii Masao

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers