T_PrivGrantee is left in NodeTag

Hi, thank you for pointing it out.

At Wed, 16 Sep 2015 14:02:30 +0900, Yugo Nagata <nagata@sraoss.co.jp> wrote in <20150916140230.a232426c.nagata@sraoss.co.jp>

I found that codes about T_PrivGrantee was removed
by the following commit;
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=31eae6028eca4365e7165f5f33fee1ed0486aee0

but T_PrivGrantee is left in NodeTag in src/include/nodes/nodes.h.

Is it intended?

I simply forgot to remove it.

The comment for NodeTag says that,

====
* Note that the numbers of the node tags are not contiguous. We left holes
* here so that we can add more tags without changing the existing enum's.
* (Since node tag numbers never exist outside backend memory, there's no
* real harm in renumbering, it just costs a full rebuild ...)
====

However, I think it'd be better to be removed.

Thoughts? The attached patch simply removes it.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:

At Wed, 16 Sep 2015 14:02:30 +0900, Yugo Nagata <nagata@sraoss.co.jp> wrote in <20150916140230.a232426c.nagata@sraoss.co.jp>

but T_PrivGrantee is left in NodeTag in src/include/nodes/nodes.h.
Is it intended?

Thoughts? The attached patch simply removes it.

Yeah, we can just take it out I think, even in the 9.5 branch. If we
were past 9.5beta1 then I'd be worried about creating an ABI break for
third-party extensions, but we're still making ABI changes for other
things.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers