Obsolete cross-references to set_append_rel_pathlist in comments
Started by Amit Langoteover 10 years ago1 messages
My previous report and subsequently commit 70d44dd apparently missed to
notice a few more cross-references to set_append_rel_pathlist where
set_append_rel_size is now meant. Attached fixes it.
Thanks,
Amit
Attachments:
fix-obsolete-cross-references.patchtext/x-diff; name=fix-obsolete-cross-references.patchDownload
diff --git a/src/backend/optimizer/path/costsize.c b/src/backend/optimizer/path/costsize.c
index d107d76..3fc2f0c 100644
--- a/src/backend/optimizer/path/costsize.c
+++ b/src/backend/optimizer/path/costsize.c
@@ -3910,7 +3910,7 @@ set_subquery_size_estimates(PlannerInfo *root, RelOptInfo *rel)
*
* Also, the subquery could be an appendrel for which all branches are
* known empty due to constraint exclusion, in which case
- * set_append_rel_pathlist will have left the attr_widths set to zero.
+ * set_append_rel_size will have left the attr_widths set to zero.
*
* In either case, we just leave the width estimate zero until
* set_rel_width fixes it.
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c
index 404c6f5..4d107a9 100644
--- a/src/backend/optimizer/plan/createplan.c
+++ b/src/backend/optimizer/plan/createplan.c
@@ -3740,7 +3740,7 @@ make_append(List *appendplans, List *tlist)
* any selection or projection, it is a pretty cheap node.
*
* If you change this, see also create_append_path(). Also, the size
- * calculations should match set_append_rel_pathlist(). It'd be better
+ * calculations should match set_append_rel_size(). It'd be better
* not to duplicate all this logic, but some callers of this function
* aren't working from an appendrel or AppendPath, so there's noplace to
* copy the data from.
diff --git a/src/backend/optimizer/prep/prepunion.c b/src/backend/optimizer/prep/prepunion.c
index 8884fb1..ab84494 100644
--- a/src/backend/optimizer/prep/prepunion.c
+++ b/src/backend/optimizer/prep/prepunion.c
@@ -1793,7 +1793,7 @@ adjust_appendrel_attrs_mutator(Node *node,
/*
* We have to process RestrictInfo nodes specially. (Note: although
- * set_append_rel_pathlist will hide RestrictInfos in the parent's
+ * set_append_rel_size will hide RestrictInfos in the parent's
* baserestrictinfo list from us, it doesn't hide those in joininfo.)
*/
if (IsA(node, RestrictInfo))
diff --git a/src/backend/optimizer/util/plancat.c b/src/backend/optimizer/util/plancat.c
index 9442e5f..e75f724 100644
--- a/src/backend/optimizer/util/plancat.c
+++ b/src/backend/optimizer/util/plancat.c
@@ -119,7 +119,7 @@ get_relation_info(PlannerInfo *root, Oid relationObjectId, bool inhparent,
/*
* Estimate relation size --- unless it's an inheritance parent, in which
- * case the size will be computed later in set_append_rel_pathlist, and we
+ * case the size will be computed later in set_append_rel_size, and we
* must leave it zero for now to avoid bollixing the total_table_pages
* calculation.
*/