Typo in file header comment of replorigindesc.c

Started by Amit Langoteabout 10 years ago4 messages

Amit Langote

Langote_Amit_f8@lab.ntt.co.jp

about 10 years ago

1 attachment(s)

Attached fixes $SUBJECT:

s/replication_origin.c/origin.c/g

Thanks,
Amit

Attachments:

replorigindesc-file-header-comment-typo.patchtext/x-diff; name=replorigindesc-file-header-comment-typo.patchDownload

diff --git a/src/backend/access/rmgrdesc/replorigindesc.c b/src/backend/access/rmgrdesc/replorigindesc.c
index 60cf0f6..479e3b4 100644
--- a/src/backend/access/rmgrdesc/replorigindesc.c
+++ b/src/backend/access/rmgrdesc/replorigindesc.c
@@ -1,7 +1,7 @@
 /*-------------------------------------------------------------------------
  *
  * replorigindesc.c
- *	  rmgr descriptor routines for replication/logical/replication_origin.c
+ *	  rmgr descriptor routines for replication/logical/origin.c
  *
  * Portions Copyright (c) 2015, PostgreSQL Global Development Group
  *

Robert Haas

robertmhaas@gmail.com

about 10 years ago

In reply to: Amit Langote (#1)

Re: Typo in file header comment of replorigindesc.c

On Thu, Nov 19, 2015 at 5:04 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:

Attached fixes $SUBJECT:

s/replication_origin.c/origin.c/g

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Amit Langote

Langote_Amit_f8@lab.ntt.co.jp

about 10 years ago

In reply to: Robert Haas (#2)

Re: Typo in file header comment of replorigindesc.c

On 2015/11/20 10:24, Robert Haas wrote:

On Thu, Nov 19, 2015 at 5:04 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:

Attached fixes $SUBJECT:

s/replication_origin.c/origin.c/g

Committed.

Thanks!

Amit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andres Freund

andres@anarazel.de

about 10 years ago

In reply to: Amit Langote (#3)

Re: Typo in file header comment of replorigindesc.c

On 2015-11-20 10:25:20 +0900, Amit Langote wrote:

On 2015/11/20 10:24, Robert Haas wrote:

On Thu, Nov 19, 2015 at 5:04 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:

Attached fixes $SUBJECT:

s/replication_origin.c/origin.c/g

Committed.

Thanks Robert and Amit!

I do wonder however if we shouldn't just get rid of all these comments
at some point. They primarily seem to serve as boilerplate that people
get wrong over the evolution of patches.

Andres

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers