libxml2 2.9.3 breaks xml test output

Started by Christian Ullrichabout 10 years ago3 messages
#1Christian Ullrich
chris@chrullrich.net

Hello,

I just noticed that last night all built branches failed on my buildfarm
animal, jaguarundi. They all failed on the "xml" test, and the output is
essentially the same everywhere:

***************
*** 9,16 ****
   LINE 1: INSERT INTO xmltest VALUES (3, '<wrong');
                                          ^
   DETAIL:  line 1: Couldn't find end of Start Tag wrong line 1
- <wrong
-       ^
   SELECT * FROM xmltest;
    id |        data
   ----+--------------------
--- 9,14 ----
***************
*** 63,70 ****
   LINE 1: SELECT xmlconcat('bad', '<syntax');
                                   ^
   DETAIL:  line 1: Couldn't find end of Start Tag syntax line 1
- <syntax
-        ^
   SELECT xmlconcat('<foo/>', NULL, '<?xml version="1.1" 
standalone="no"?><bar/>');
     xmlconcat
   --------------

The last thing I did in regard to XML on this system was upgrade libxml2
from 2.9.2 to 2.9.3. I bisected it a a bit and the guilty commit to
libxml2 is ce0b0d0d8 "Do not print error context when there is none"
from about two weeks ago.

I have zero experience with libxml2, so no idea if the previous context
level can be turned on again. IMHO, the libxml2 change is a bug in
itself; PostgreSQL's error messages are more readable with the XML text
in them.

--
Christian

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Michael Paquier
michael.paquier@gmail.com
In reply to: Christian Ullrich (#1)
Re: libxml2 2.9.3 breaks xml test output

On Sat, Dec 5, 2015 at 4:38 PM, Christian Ullrich <chris@chrullrich.net> wrote:

I have zero experience with libxml2, so no idea if the previous context
level can be turned on again. IMHO, the libxml2 change is a bug in itself;
PostgreSQL's error messages are more readable with the XML text in them.

See here for example you are not the only one to see this problem:
/messages/by-id/CAFj8pRA4xJQFGNQCqMCYGx-umgMr3Stt3xFEUw7kBsOiOvGhkA@mail.gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1286692
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Christian Ullrich
chris@chrullrich.net
In reply to: Michael Paquier (#2)
Re: libxml2 2.9.3 breaks xml test output

* Michael Paquier wrote:

On Sat, Dec 5, 2015 at 4:38 PM, Christian Ullrich <chris@chrullrich.net> wrote:

I have zero experience with libxml2, so no idea if the previous context
level can be turned on again. IMHO, the libxml2 change is a bug in itself;
PostgreSQL's error messages are more readable with the XML text in them.

See here for example you are not the only one to see this problem:
/messages/by-id/CAFj8pRA4xJQFGNQCqMCYGx-umgMr3Stt3xFEUw7kBsOiOvGhkA@mail.gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1286692

Right. Sorry, I had checked the archives for earlier mentions of the
issue, but had not found Pavel's post.

--
Christian

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers