Comment typo in pg_upgrade.c

Started by Amit Langoteabout 10 years ago2 messages
#1Amit Langote
Langote_Amit_f8@lab.ntt.co.jp
1 attachment(s)

In prepare_new_cluster(), following looks like a typo:

-     * would cause us to lose the frozenids restored by the load. We use
+     * would cause us to lose the frozenxids restored by the load. We use

Attached find the patch.

Thanks,
Amit

Attachments:

typo-pg-upgrade.patchtext/x-diff; name=typo-pg-upgrade.patchDownload
diff --git a/src/bin/pg_upgrade/pg_upgrade.c b/src/bin/pg_upgrade/pg_upgrade.c
index 4a7281b..7f8b75f 100644
--- a/src/bin/pg_upgrade/pg_upgrade.c
+++ b/src/bin/pg_upgrade/pg_upgrade.c
@@ -238,7 +238,7 @@ prepare_new_cluster(void)
 {
 	/*
 	 * It would make more sense to freeze after loading the schema, but that
-	 * would cause us to lose the frozenids restored by the load. We use
+	 * would cause us to lose the frozenxids restored by the load. We use
 	 * --analyze so autovacuum doesn't update statistics later
 	 */
 	prep_status("Analyzing all rows in the new cluster");
#2Amit Langote
Langote_Amit_f8@lab.ntt.co.jp
In reply to: Amit Langote (#1)
Re: Comment typo in pg_upgrade.c

On 2015/12/18 14:53, Amit Langote wrote:

In prepare_new_cluster(), following looks like a typo:

-     * would cause us to lose the frozenids restored by the load. We use
+     * would cause us to lose the frozenxids restored by the load. We use

Or maybe not, because "frozenids" is supposed to refer to both xids and mxids.

Sorry about the noise.

Thanks,
Amit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers