Typo in the comment above heap_prepare_freeze_tuple()
I think the following may be a typo:
* Caller is responsible for ensuring that no other backend can access the
* storage underlying this tuple, either by holding an exclusive lock on the
- * buffer containing it (which is what lazy VACUUM does), or by having it by
+ * buffer containing it (which is what lazy VACUUM does), or by having it be
* in private storage (which is what CLUSTER and friends do).If so, attached is the patch.
Thanks,
Amit
Attachments:
comment-typo-heap_prepare_freeze_tuple.patchtext/x-diff; name=comment-typo-heap_prepare_freeze_tuple.patchDownload
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 9ff7a41..3c2878b 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -6547,7 +6547,7 @@ heap_prepare_freeze_tuple(HeapTupleHeader tuple, TransactionId cutoff_xid,
*
* Caller is responsible for ensuring that no other backend can access the
* storage underlying this tuple, either by holding an exclusive lock on the
- * buffer containing it (which is what lazy VACUUM does), or by having it by
+ * buffer containing it (which is what lazy VACUUM does), or by having it be
* in private storage (which is what CLUSTER and friends do).
*
* Note: it might seem we could make the changes without exclusive lock, since
On Fri, Dec 18, 2015 at 1:25 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
I think the following may be a typo:
* Caller is responsible for ensuring that no other backend can access the * storage underlying this tuple, either by holding an exclusive lock on the - * buffer containing it (which is what lazy VACUUM does), or by having it by + * buffer containing it (which is what lazy VACUUM does), or by having it be * in private storage (which is what CLUSTER and friends do).If so, attached is the patch.
Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 2015/12/19 2:05, Robert Haas wrote:
On Fri, Dec 18, 2015 at 1:25 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:I think the following may be a typo:
* Caller is responsible for ensuring that no other backend can access the * storage underlying this tuple, either by holding an exclusive lock on the - * buffer containing it (which is what lazy VACUUM does), or by having it by + * buffer containing it (which is what lazy VACUUM does), or by having it be * in private storage (which is what CLUSTER and friends do).If so, attached is the patch.
Committed.
Thanks!
Regards,
Amit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers