request patch pg_recvlogical.c, pg_receivexlog.c for nls
Hello,
at PostgreSQL version 9.5rc1,
at line 934 in pg_recvlogical.c
set_pglocale_pgservice(argv[0],PG_TEXTDOMAIN("pg_recvlogical"));
this references invalid catalog file, because pg_basebackup,
pg_recvlogical, pg_receivexlog commands use same catalog file
pg_basebackup.mo
pg_receivexlog.c too.
patch please.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Dec 28, 2015 at 5:07 PM, Ioseph Kim <pgsql-kr@postgresql.kr> wrote:
Hello,
at PostgreSQL version 9.5rc1,
at line 934 in pg_recvlogical.cset_pglocale_pgservice(argv[0],PG_TEXTDOMAIN("pg_recvlogical"));
this references invalid catalog file, because pg_basebackup,
pg_recvlogical, pg_receivexlog commands use same catalog file
pg_basebackup.mopg_receivexlog.c too.
patch please.
Yes, you are right. Both values do not match CATALOG_NAME in nls.mk. I
guess that something like the attached is fine then... The other
binaries are fine.
--
Michael
Attachments:
20151228_catalog_name_fix.patchtext/x-patch; charset=US-ASCII; name=20151228_catalog_name_fix.patchDownload
diff --git a/src/bin/pg_basebackup/pg_receivexlog.c b/src/bin/pg_basebackup/pg_receivexlog.c
index 0c322d1..c4a6062 100644
--- a/src/bin/pg_basebackup/pg_receivexlog.c
+++ b/src/bin/pg_basebackup/pg_receivexlog.c
@@ -383,7 +383,7 @@ main(int argc, char **argv)
char *db_name;
progname = get_progname(argv[0]);
- set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pg_receivexlog"));
+ set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pg_basebackup"));
if (argc > 1)
{
diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c
index 93f61c3..b568a78 100644
--- a/src/bin/pg_basebackup/pg_recvlogical.c
+++ b/src/bin/pg_basebackup/pg_recvlogical.c
@@ -645,7 +645,7 @@ main(int argc, char **argv)
char *db_name;
progname = get_progname(argv[0]);
- set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pg_recvlogical"));
+ set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pg_basebackup"));
if (argc > 1)
{
Michael Paquier wrote:
On Mon, Dec 28, 2015 at 5:07 PM, Ioseph Kim <pgsql-kr@postgresql.kr> wrote:
at PostgreSQL version 9.5rc1,
at line 934 in pg_recvlogical.cset_pglocale_pgservice(argv[0],PG_TEXTDOMAIN("pg_recvlogical"));
this references invalid catalog file, because pg_basebackup,
pg_recvlogical, pg_receivexlog commands use same catalog file
pg_basebackup.mopg_receivexlog.c too.
patch please.
Yes, you are right. Both values do not match CATALOG_NAME in nls.mk. I
guess that something like the attached is fine then... The other
binaries are fine.
Oops. We should have noticed this a long ago, since pg_receivexlog was
introduced in 9.2 and pg_recvlogical in 9.4 ... judging by the
misalignment in the spanish translation for --help, I have never tested
the output of those programs.
Pushed and backpatched as appropriate. Thanks.
--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers