Close handle leak in SSPI auth

Started by Christian Ullrichover 10 years ago2 messageshackers
Jump to latest
#1Christian Ullrich
chris@chrullrich.net

Hello,

here's a one-line patch to close a handle leak in pg_SSPI_recvauth().

According to the docs, the token retrieved with
QuerySecurityContextToken() must be closed.

--
Christian

Attachments:

sspi_close_handle.patchtext/plain; charset=UTF-8; name=sspi_close_handle.patchDownload+2-0
#2Magnus Hagander
magnus@hagander.net
In reply to: Christian Ullrich (#1)
Re: Close handle leak in SSPI auth

On Sun, Jan 10, 2016 at 8:58 PM, Christian Ullrich <chris@chrullrich.net>
wrote:

Hello,

here's a one-line patch to close a handle leak in pg_SSPI_recvauth().

According to the docs, the token retrieved with
QuerySecurityContextToken() must be closed.

We still leak it in a number of the error paths in this case, but I don't
think we need to care about those -- since they are hard errors, the
process exits shortly thereafter anyway.

Applied and backpatched, thanks.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/