Typo in sequence.c

Started by Vinayak Pokalealmost 10 years ago2 messages
#1Vinayak Pokale
vinpokale@gmail.com
1 attachment(s)

Hi,

I found a typo in sequence.c
Please check the attached patch.

Regards,
Vinayak

Attachments:

typo-sequence-c.patchapplication/octet-stream; name=typo-sequence-c.patchDownload
diff --git a/src/backend/commands/sequence.c b/src/backend/commands/sequence.c
index c98f981..25c57f6 100644
--- a/src/backend/commands/sequence.c
+++ b/src/backend/commands/sequence.c
@@ -433,7 +433,7 @@ AlterSequence(AlterSeqStmt *stmt)
 		aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS,
 					   stmt->sequence->relname);
 
-	/* lock page' buffer and read tuple into new sequence structure */
+	/* lock page buffer and read tuple into new sequence structure */
 	seq = read_seq_tuple(elm, seqrel, &buf, &seqtuple);
 
 	/* Copy old values of options into workspace */
@@ -582,7 +582,7 @@ nextval_internal(Oid relid)
 		return elm->last;
 	}
 
-	/* lock page' buffer and read tuple */
+	/* lock page buffer and read tuple */
 	seq = read_seq_tuple(elm, seqrel, &buf, &seqtuple);
 	page = BufferGetPage(buf);
 
@@ -876,7 +876,7 @@ do_setval(Oid relid, int64 next, bool iscalled)
 	 */
 	PreventCommandIfParallelMode("setval()");
 
-	/* lock page' buffer and read tuple */
+	/* lock page buffer and read tuple */
 	seq = read_seq_tuple(elm, seqrel, &buf, &seqtuple);
 
 	if ((next < seq->min_value) || (next > seq->max_value))
#2Bruce Momjian
bruce@momjian.us
In reply to: Vinayak Pokale (#1)
Re: [HACKERS] Typo in sequence.c

On Fri, Jan 15, 2016 at 01:18:03PM +0900, Vinayak Pokale wrote:

Hi,

I found a typo in sequence.c
Please check the attached patch.

I am not sure how to put this, but the typos are still there seven years
after you reported it, so fixed in master.

---------------------------------------------------------------------------

diff --git a/src/backend/commands/sequence.c b/src/backend/commands/sequence.c
index c98f981..25c57f6 100644
--- a/src/backend/commands/sequence.c
+++ b/src/backend/commands/sequence.c
@@ -433,7 +433,7 @@ AlterSequence(AlterSeqStmt *stmt)
aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS,
stmt->sequence->relname);
-	/* lock page' buffer and read tuple into new sequence structure */
+	/* lock page buffer and read tuple into new sequence structure */
seq = read_seq_tuple(elm, seqrel, &buf, &seqtuple);

/* Copy old values of options into workspace */
@@ -582,7 +582,7 @@ nextval_internal(Oid relid)
return elm->last;
}

-	/* lock page' buffer and read tuple */
+	/* lock page buffer and read tuple */
seq = read_seq_tuple(elm, seqrel, &buf, &seqtuple);
page = BufferGetPage(buf);

@@ -876,7 +876,7 @@ do_setval(Oid relid, int64 next, bool iscalled)
*/
PreventCommandIfParallelMode("setval()");

-	/* lock page' buffer and read tuple */
+	/* lock page buffer and read tuple */
seq = read_seq_tuple(elm, seqrel, &buf, &seqtuple);

if ((next < seq->min_value) || (next > seq->max_value))

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.