Ununsed member in printQueryOpt

Started by Dickson S. Guedesalmost 10 years ago2 messages
#1Dickson S. Guedes
listas@guedesoft.net

I found the following code in src/bin/psql/print.h:155 (master 1d0c3b3f8a)

bool quote; /* quote all values as much as possible */

That code was there since:

commit a45195a191eec367a4f305bb71ab541d17a3b9f9
Author: Bruce Momjian <bruce@momjian.us>
Date: Thu Nov 4 21:56:02 1999 +0000

Major psql overhaul by Peter Eisentraut.

But I didn't found any other references to that "quote" and, after
removing that line,
the code still compiles without any error/warning.

Did I overlook something?

Best regards,
--
Dickson S. Guedes
mail/xmpp: guedes@guedesoft.net - skype: guediz
http://github.com/guedes - http://guedesoft.net
http://www.postgresql.org.br

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Dickson S. Guedes (#1)
Re: Ununsed member in printQueryOpt

"Dickson S. Guedes" <listas@guedesoft.net> writes:

I found the following code in src/bin/psql/print.h:155 (master 1d0c3b3f8a)
bool quote; /* quote all values as much as possible */
But I didn't found any other references to that "quote" and, after
removing that line,
the code still compiles without any error/warning.

Yeah, you're right, this seems to be dead code. Removed.
Thanks for noticing!

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers