backpatch for REL9_4_STABLE of commit 40482e606733675eb9e5b2f7221186cf81352da1

Started by Huong Dangminhalmost 10 years ago4 messages
#1Huong Dangminh
huo-dangminh@ys.jp.nec.com
1 attachment(s)

Hi,

I think this fixed is also required for REL9_4_STABLE.
Please confirm the attached patch.

Thanks and best regards,
Dang Minh Huong
NEC Solution Innovators, Ltd.
http://www.nec-solutioninnovators.co.jp/en/

Attachments:

ecpg.9.4.patchapplication/octet-stream; name=ecpg.9.4.patchDownload
diff --git a/src/interfaces/ecpg/include/datetime.h b/src/interfaces/ecpg/include/datetime.h
index e7d6d21..c4161a9 100644
--- a/src/interfaces/ecpg/include/datetime.h
+++ b/src/interfaces/ecpg/include/datetime.h
@@ -5,8 +5,8 @@
 
 #include <ecpg_informix.h>
 
-#ifndef _ECPGLIB_H				/* source created by ecpg which defines these
-								 * symbols */
+/* source created by ecpg which defines these symbols */ 
+#ifndef _ECPGLIB_H
 typedef timestamp dtime_t;
 typedef interval intrvl_t;
 #endif   /* ndef _ECPGLIB_H */
diff --git a/src/interfaces/ecpg/include/decimal.h b/src/interfaces/ecpg/include/decimal.h
index 7efed47..8b44998 100644
--- a/src/interfaces/ecpg/include/decimal.h
+++ b/src/interfaces/ecpg/include/decimal.h
@@ -5,8 +5,8 @@
 
 #include <ecpg_informix.h>
 
-#ifndef _ECPGLIB_H				/* source created by ecpg which defines this
-								 * symbol */
+/* source created by ecpg which defines this */ 
+#ifndef _ECPGLIB_H
 typedef decimal dec_t;
 #endif   /* ndef _ECPGLIB_H */
 
#2Haribabu Kommi
kommi.haribabu@gmail.com
In reply to: Huong Dangminh (#1)
Re: backpatch for REL9_4_STABLE of commit 40482e606733675eb9e5b2f7221186cf81352da1

On Mon, Feb 8, 2016 at 8:20 PM, Huong Dangminh
<huo-dangminh@ys.jp.nec.com> wrote:

Hi,

I think this fixed is also required for REL9_4_STABLE.
Please confirm the attached patch.

Yes, this fix was missed for 9.4 stable branch during back patch
and it is available on all other supported branches.

Regards,
Hari Babu
Fujitsu Australia

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Andres Freund
andres@anarazel.de
In reply to: Haribabu Kommi (#2)
Re: backpatch for REL9_4_STABLE of commit 40482e606733675eb9e5b2f7221186cf81352da1

On 2016-02-08 20:59:25 +1100, Haribabu Kommi wrote:

On Mon, Feb 8, 2016 at 8:20 PM, Huong Dangminh
<huo-dangminh@ys.jp.nec.com> wrote:

Hi,

I think this fixed is also required for REL9_4_STABLE.
Please confirm the attached patch.

Yes, this fix was missed for 9.4 stable branch during back patch
and it is available on all other supported branches.

Since this evidently was an omission, I backpatched the relevant commit
to 9.4. That seems prudent, given that the issue is documented to be
fixed there...

Thanks for the report.

Andres

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Michael Meskes
meskes@postgresql.org
In reply to: Huong Dangminh (#1)
Re: backpatch for REL9_4_STABLE of commit 40482e606733675eb9e5b2f7221186cf81352da1

On Mon, Feb 08, 2016 at 09:20:46AM +0000, Huong Dangminh wrote:

I think this fixed is also required for REL9_4_STABLE.
Please confirm the attached patch.

Sure thing, no idea where that cherry-pick got lost.

Thanks.

Michael

--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers