transam README small fix

Started by Stas Kelvichalmost 10 years ago3 messages

s.kelvich@postgrespro.ru

almost 10 years ago

1 attachment(s)

Hi,

Transaction function call sequence description in transam/README is slightly outdated. Select now handled by PortalRunSelect instead of ProcessQuery. It is also hard to follow what tabulation there means — sometimes that means “function called by function”, sometimes it isn't. So I’ve also changed it to actual call nesting.

Attachments:

transam.readme.patchapplication/octet-stream; name=transam.readme.patchDownload

diff --git a/src/backend/access/transam/README b/src/backend/access/transam/README
index f6db580..617a545 100644
--- a/src/backend/access/transam/README
+++ b/src/backend/access/transam/README
@@ -61,23 +61,23 @@ sequence:
 
      /  StartTransactionCommand;
     /       StartTransaction;
-1) <        ProcessUtility;             << BEGIN
+1) <    ProcessUtility;                 << BEGIN
     \       BeginTransactionBlock;
      \  CommitTransactionCommand;
 
     /   StartTransactionCommand;
-2) /        ProcessQuery;               << SELECT ...
-   \        CommitTransactionCommand;
+2) /    PortalRunSelect;                << SELECT ...
+   \    CommitTransactionCommand;
     \       CommandCounterIncrement;
 
     /   StartTransactionCommand;
-3) /        ProcessQuery;               << INSERT ...
-   \        CommitTransactionCommand;
+3) /    ProcessQuery;                   << INSERT ...
+   \    CommitTransactionCommand;
     \       CommandCounterIncrement;
 
      /  StartTransactionCommand;
     /   ProcessUtility;                 << COMMIT
-4) <            EndTransactionBlock;
+4) <        EndTransactionBlock;
     \   CommitTransactionCommand;
      \      CommitTransaction;

Robert Haas

robertmhaas@gmail.com

almost 10 years ago

In reply to: Stas Kelvich (#1)

Re: transam README small fix

On Tue, Mar 1, 2016 at 4:31 AM, Stas Kelvich <s.kelvich@postgrespro.ru> wrote:

Transaction function call sequence description in transam/README is slightly outdated. Select now handled by PortalRunSelect instead of ProcessQuery. It is also hard to follow what tabulation there means — sometimes that means “function called by function”, sometimes it isn't. So I’ve also changed it to actual call nesting.

After some study, this looks good to me, so committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Stas Kelvich

s.kelvich@postgrespro.ru

almost 10 years ago

In reply to: Robert Haas (#2)

Re: transam README small fix

Thanks.

Stas Kelvich
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

On 04 Mar 2016, at 22:14, Robert Haas <robertmhaas@gmail.com> wrote:

On Tue, Mar 1, 2016 at 4:31 AM, Stas Kelvich <s.kelvich@postgrespro.ru> wrote:

Transaction function call sequence description in transam/README is slightly outdated. Select now handled by PortalRunSelect instead of ProcessQuery. It is also hard to follow what tabulation there means — sometimes that means “function called by function”, sometimes it isn't. So I’ve also changed it to actual call nesting.

After some study, this looks good to me, so committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers