SSL indicator in psql prompt

Started by Peter Eisentrautabout 10 years ago6 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

I like how browsers show a little lock in the address bar depending on
whether SSL is in use. This could be useful in psql as well. Here is a
prototype patch.

Example:

Put this in .psqlrc:

\set PROMPT1 '%s%/%R%# '

$ psql test
psql (9.6devel)
Type "help" for help.

🔒test=#

Without SSL:

🃏test=#

Comments?

Attachments:

0001-psql-Add-s-prompt-placeholder-for-SSL-status.patchapplication/x-patch; name=0001-psql-Add-s-prompt-placeholder-for-SSL-status.patchDownload+29-1
#2Shulgin, Oleksandr
oleksandr.shulgin@zalando.de
In reply to: Peter Eisentraut (#1)
Re: SSL indicator in psql prompt

On Fri, Apr 1, 2016 at 2:52 PM, Peter Eisentraut <peter_e@gmx.net> wrote:

I like how browsers show a little lock in the address bar depending on
whether SSL is in use. This could be useful in psql as well. Here is a
prototype patch.

Example:

Put this in .psqlrc:

\set PROMPT1 '%s%/%R%# '

$ psql test
psql (9.6devel)
Type "help" for help.

🔒test=#

Without SSL:

🃏test=#

Comments?

Sounds reasonable. What is the meaning of the latter symbol?

--
Alex

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: SSL indicator in psql prompt

Peter Eisentraut <peter_e@gmx.net> writes:

I like how browsers show a little lock in the address bar depending on
whether SSL is in use. This could be useful in psql as well. Here is a
prototype patch.
Comments?

-1 on the hard-coded UTF8, even with the encoding check (which I don't
think is terribly trustworthy). How about defining it in a way that
lets/makes the user provide the character(s) to print?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Robert Haas
robertmhaas@gmail.com
In reply to: Tom Lane (#3)
Re: SSL indicator in psql prompt

On Fri, Apr 1, 2016 at 10:15 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

I like how browsers show a little lock in the address bar depending on
whether SSL is in use. This could be useful in psql as well. Here is a
prototype patch.
Comments?

-1 on the hard-coded UTF8, even with the encoding check (which I don't
think is terribly trustworthy). How about defining it in a way that
lets/makes the user provide the character(s) to print?

I think you have been trolled. Note the date.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Shulgin, Oleksandr
oleksandr.shulgin@zalando.de
In reply to: Robert Haas (#4)
Re: SSL indicator in psql prompt

On Apr 4, 2016 17:54, "Robert Haas" <robertmhaas@gmail.com> wrote:

On Fri, Apr 1, 2016 at 10:15 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

I like how browsers show a little lock in the address bar depending on
whether SSL is in use. This could be useful in psql as well. Here is

a

prototype patch.
Comments?

-1 on the hard-coded UTF8, even with the encoding check (which I don't
think is terribly trustworthy). How about defining it in a way that
lets/makes the user provide the character(s) to print?

I think you have been trolled. Note the date.

Are you trying to say that this feature is in your opinion useless?

Even if that's an April Fools patch, I don't thiy it is entirely out of
scope. :-)

--
Alex

#6Robert Haas
robertmhaas@gmail.com
In reply to: Shulgin, Oleksandr (#5)
Re: SSL indicator in psql prompt

On Mon, Apr 4, 2016 at 12:07 PM, Shulgin, Oleksandr
<oleksandr.shulgin@zalando.de> wrote:

On Apr 4, 2016 17:54, "Robert Haas" <robertmhaas@gmail.com> wrote:

On Fri, Apr 1, 2016 at 10:15 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

I like how browsers show a little lock in the address bar depending on
whether SSL is in use. This could be useful in psql as well. Here is
a
prototype patch.
Comments?

-1 on the hard-coded UTF8, even with the encoding check (which I don't
think is terribly trustworthy). How about defining it in a way that
lets/makes the user provide the character(s) to print?

I think you have been trolled. Note the date.

Are you trying to say that this feature is in your opinion useless?

Well, what I was trying to say is that I don't think the proposal was
100% serious. However, I also don't think it's particularly useful.
I am not a big fan of cluttering up the psql command line with random
Unicode glyphs. It's easy enough to find out whether you've got an
SSL connection if you want to, with \conninfo. I don't think it needs
to be part of every prompt.

YMMV, of course.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers