Unused macros in src/include/access/transam.h
Hi all,
When dealing with some patch review I've noticed there are two macro is not
used anywhere:
#define TransactionIdStore(xid, dest) (*(dest) = (xid))
#define StoreInvalidTransactionId(dest) (*(dest) = InvalidTransactionId)
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
Show quoted text
Timbira: http://www.timbira.com.br
Blog: http://fabriziomello.github.io
Linkedin: http://br.linkedin.com/in/fabriziomello
Twitter: http://twitter.com/fabriziomello
Github: http://github.com/fabriziomello
On Wed, Apr 6, 2016 at 4:55 AM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
Hi all,
When dealing with some patch review I've noticed there are two macro is not
used anywhere:#define TransactionIdStore(xid, dest) (*(dest) = (xid))
#define StoreInvalidTransactionId(dest) (*(dest) = InvalidTransactionId)
Not by the core code, perhaps they are used by extensions though. The
last bit of code using TransactionIdStore is from 2007 (282d2a03), by
the way. Still, knowing the low level of maintenance those are
requiring, it does not seem worth a compilation breakage I think.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers