Mar 2021

2 commits
Add libpq pipeline mode support to pgbench
15 Mar 2021Alvaro Herreramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1251 of 1 reviewer saw the final version

Matches the pgbench patch in #125, with its documentation transferred from the libpq patch, the assertion correction discussed in #126 and #127, and test/documentation refinements including a prepared-mode test. Both the submitted patch and commit credit Daniel Vérité as author.

  • Álvaro Herrerasaw the final versiontrailerHe repaired and benchmarked the pgbench integration in #125, supplied the assertion fix in #127, and committed the final version.
Implement pipeline mode in libpq
15 Mar 2021Alvaro Herreramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: Re: PATCH: Batch/pipelining support for libpq (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1250 of 10 reviewers saw the final version

Applying the libpq attachment from #125 to the commit's parent reproduces every committed file exactly except doc/src/sgml/ref/pgbench.sgml, whose additions moved to the companion commit. This March 2021 source is later than every supplied patchset in thread #42876, so the final landing belongs here.

  • Andres Freundsaw an earlier versiontrailerHe reviewed API and error handling, benchmarked batching, supplied the syscall-reduction delta in #85, and reviewed #107 in #108 before the later queue redesign.
  • Aya Iwatasaw an earlier versiontrailerShe inspected and rebased Craig's patch and corrected its documentation example in #34, well before the final API and queue rework.
  • Daniel Véritésaw an earlier versiontrailerHe found queue-count, single-row, large-object, and COPY-test problems and examined buffering in #87, before substantial later implementation changes.
  • David G. Johnstonno review foundtrailerDocumentation suggestions are acknowledged in #122 and #124, but his review messages and an identifiable reviewed submission are absent from this thread.
  • Justin Pryzbyno review foundtrailerEarlier fixes are acknowledged in #110 without their review messages, while his concrete review in #126 concerns the separate pgbench assertion.
  • Kirk Jamisonno review foundtrailerNo message or identifiable review activity by him appears in the supplied thread.
  • Michael Paquiersaw an earlier versiontrailerHis reviews found queue cleanup failures, shaped the API and TAP tests, and repeatedly reproduced COPY-test failures through #62, before the final redesign.
  • Nikhil Sontakkesaw an earlier versiontrailerHe refreshed the implementation and repaired test timing portability in #105, before automatic queue processing and the unified command queue.
  • Vaishnavi Prabakaransaw an earlier versiontrailerShe incorporated earlier reviews, reproduced and replaced Daniel's single-row fix in #47, and developed bounded buffering in #90 before the later redesign.
  • Zhihong Yusaw an earlier versiontrailerHe identified a documentation typo and missing test-file license information in #120, before PQsendQuery support and the command-queue rework.

Credits across 2 commits

Author
Daniel Verite1
Reviewer
Alvaro Herrera1
Andres Freund1
Daniel Verite1
David G. Johnston1
Iwata, Aya1
Justin Pryzby1
k.jamison@fujitsu.com1
Michael Paquier1
Nikhil Sontakke1
Prabakaran, Vaishnavi1
Zhihong Yu1
Co author
Alvaro Herrera1
Craig Ringer1
Matthieu Garrigues1
Committer
Alvaro Herrera2