effective_io_concurrency in 9.6beta

Jeff Janes <jeff.janes@gmail.com> writes:

commit 1aba62ec made zero be an illegal value for effective_io_concurrency.
i think this was an accident. If not, then the sample postgresql.conf
(at least) needs to be updated.

It looks like the problem is that the new range check

+   /* This range check shouldn't fail, but let's be paranoid */
+   return (new_prefetch_pages > 0.0 && new_prefetch_pages < (double) INT_MAX);

should be testing for >= 0.0 not > 0.0.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tom Lane wrote:

Jeff Janes <jeff.janes@gmail.com> writes:

commit 1aba62ec made zero be an illegal value for effective_io_concurrency.
i think this was an accident. If not, then the sample postgresql.conf
(at least) needs to be updated.

It looks like the problem is that the new range check

+   /* This range check shouldn't fail, but let's be paranoid */
+   return (new_prefetch_pages > 0.0 && new_prefetch_pages < (double) INT_MAX);

should be testing for >= 0.0 not > 0.0.

Hmm, yeah, it looks like that's it. Will fix.

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Tue, May 24, 2016 at 11:34 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:

Tom Lane wrote:

Jeff Janes <jeff.janes@gmail.com> writes:

commit 1aba62ec made zero be an illegal value for effective_io_concurrency.
i think this was an accident. If not, then the sample postgresql.conf
(at least) needs to be updated.

It looks like the problem is that the new range check

+   /* This range check shouldn't fail, but let's be paranoid */
+   return (new_prefetch_pages > 0.0 && new_prefetch_pages < (double) INT_MAX);

should be testing for >= 0.0 not > 0.0.

Hmm, yeah, it looks like that's it. Will fix.

Thanks, works as expected now.

Cheers,

Jeff

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers