Jun - Jul 2023

2 commits
libpq: Add support for Close on portals and statements
4 Jul 2023Michael Paquiermaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 98% surepart of a posted patchsetlight changesfrom patchset #201 of 2 reviewers saw the final version

28b5726561 lands the Close-feature member of the two-patch series in #20; the diagnostic prerequisite landed separately. Differences within the feature are light: documentation whitespace, helper comments, omission of one test progress-label change, and correction of the PQsendClosePrepared failure diagnostic in src/test/modules/libpq_pipeline/libpq_pipeline.c.

  • Jian Hesaw an earlier versiontrailerJian reported the missing exports, tested successive versions, and identified documentation and comment errors #6 #8 #11 #15, before the send-helper refactoring in #18.
  • Michael Paquiersaw the final versiontrailerMichael requested asynchronous tests, helper consolidation, and clearer test output #10 #17 #19, then committed the final version and documented its diagnostic correction #24 #25.
Fix incorrect error message in libpq_pipeline
23 Jun 2023Michael Paquiermaster16beta2REL_19_STABLE16beta2REL_18_STABLE16beta2REL_17_STABLE16beta2REL_16_STABLE16beta2REL_15_STABLE15.4REL_14_STABLE14.9
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #201 of 1 reviewer saw the final version

f69a7f08fd exactly matches the standalone diagnostic-fix member of #20, replacing "expected NULL result" with "PQgetResult returned null" in test_prepared(). It is a subset of that two-patch submission, leaving the Close feature for a later commit.

  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Jelte Fennema-Nio2
Reviewer
Michael Paquiercommitter2
jian he1
Committer
Michael Paquier2