Binary I/O for isn extension

Started by Shay Rojanskyover 10 years ago11 messageshackers
Jump to latest
#1Shay Rojansky
roji@roji.org

Hi.

Attached is a small patch which adds binary input/output for the types
added by the isn extension.

Shay

Attachments:

isn-binary.patchapplication/octet-stream; name=isn-binary.patchDownload+51-0
#2Andreas Karlsson
andreas.karlsson@percona.com
In reply to: Shay Rojansky (#1)
Re: Binary I/O for isn extension

Hi,

Thanks for the patch, you can add it to our commitfest app so it gets
reviewed in the next commitfest.

https://commitfest.postgresql.org/

A suggestion to make it easier for your patch to be accepted:

When adding new functions to an extension you need to bump the version
of the extension by renaming the file, updating the .control file,
creating an upgrade script, and updating the Makefile to include the new
files.

Andreas

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Fabien COELHO
coelho@cri.ensmp.fr
In reply to: Shay Rojansky (#1)
Re: Binary I/O for isn extension

Hello,

Attached is a small patch which adds binary input/output for the types
added by the isn extension.

I added this patch to the next CF (2016-09) under "Miscellaneous".

Out of curiosity, what is the motivation?

--
Fabien.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Shay Rojansky
roji@roji.org
In reply to: Andreas Karlsson (#2)
Re: Binary I/O for isn extension

When adding new functions to an extension you need to bump the version of
the extension by renaming the file, updating the .control file, creating an
upgrade script, and updating the Makefile to include the new files.

Thanks for the guidance, I'll fix all that and resubmit a patch.

#5Fabien COELHO
coelho@cri.ensmp.fr
In reply to: Andreas Karlsson (#2)
Re: Binary I/O for isn extension

Thanks for the patch, you can add it to our commitfest app so it gets
reviewed in the next commitfest.

I did this.

A suggestion to make it easier for your patch to be accepted:

When adding new functions to an extension you need to bump the version of the
extension by renaming the file, updating the .control file, creating an
upgrade script, and updating the Makefile to include the new files.

Indeed.

Moreover I'm not sure that a type may me updated incrementaly to add new
send/receive functions.

--
Fabien.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#6Shay Rojansky
roji@roji.org
In reply to: Fabien COELHO (#3)
Re: Binary I/O for isn extension

I added this patch to the next CF (2016-09) under "Miscellaneous".

Thanks!

Out of curiosity, what is the motivation?

I'm the owner of Npgsql, the open-source .NET driver for PostgreSQL, which
is a binary-first driver. That is, working with types that have no binary
I/O is possible but awkward.

I hope the general direction is (or will be) to have binary I/O for all
supported types, both for compatibility with binary-first consumers such as
Npgsql and for general efficiency.

#7Shay Rojansky
roji@roji.org
In reply to: Andreas Karlsson (#2)
Re: Binary I/O for isn extension

When adding new functions to an extension you need to bump the version of
the extension by renaming the file, updating the .control file, creating an
upgrade script, and updating the Makefile to include the new files.

Attached is a new version of the patch, adding an upgrade script and the
rest of it. Note that because, as Fabien noted, there's doesn't seem to be
a way to add send/receive functions with ALTER TYPE, I did that by updating
pg_type directly - hope that's OK.

Attachments:

isn-binary.patchapplication/octet-stream; name=isn-binary.patchDownload+3264-3200
#8Fabien COELHO
coelho@cri.ensmp.fr
In reply to: Shay Rojansky (#7)
Re: Binary I/O for isn extension

Hello Shay,

Attached is a new version of the patch, adding an upgrade script and the
rest of it. Note that because, as Fabien noted, there's doesn't seem to be
a way to add send/receive functions with ALTER TYPE, I did that by updating
pg_type directly - hope that's OK.

This patch does not apply anymore, because there as been an update in
between to mark relevant contrib functions as "parallel".

Could you update the patch?

--
Fabien.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#9Robert Haas
robertmhaas@gmail.com
In reply to: Fabien COELHO (#8)
Re: Binary I/O for isn extension

On Mon, Aug 22, 2016 at 8:14 AM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:

Hello Shay,

Attached is a new version of the patch, adding an upgrade script and the
rest of it. Note that because, as Fabien noted, there's doesn't seem to be
a way to add send/receive functions with ALTER TYPE, I did that by
updating
pg_type directly - hope that's OK.

This patch does not apply anymore, because there as been an update in
between to mark relevant contrib functions as "parallel".

Could you update the patch?

So, it's been over a month since this request, and there doesn't seem
to be an update to this patch. The CommitFest is over in 2 days, so
I've marked this "Returned with Feedback". Shay, please feel free to
resubmit for the next CommitFest.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#10Shay Rojansky
roji@roji.org
In reply to: Robert Haas (#9)
Re: Binary I/O for isn extension

Sorry about this, I just haven't had a free moment (and it's definitely not
very high priority...)

On Wed, Sep 28, 2016 at 5:04 PM, Robert Haas <robertmhaas@gmail.com> wrote:

Show quoted text

On Mon, Aug 22, 2016 at 8:14 AM, Fabien COELHO <coelho@cri.ensmp.fr>
wrote:

Hello Shay,

Attached is a new version of the patch, adding an upgrade script and the
rest of it. Note that because, as Fabien noted, there's doesn't seem to

be

a way to add send/receive functions with ALTER TYPE, I did that by
updating
pg_type directly - hope that's OK.

This patch does not apply anymore, because there as been an update in
between to mark relevant contrib functions as "parallel".

Could you update the patch?

So, it's been over a month since this request, and there doesn't seem
to be an update to this patch. The CommitFest is over in 2 days, so
I've marked this "Returned with Feedback". Shay, please feel free to
resubmit for the next CommitFest.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#11Robert Haas
robertmhaas@gmail.com
In reply to: Shay Rojansky (#10)
Re: Binary I/O for isn extension

On Wed, Sep 28, 2016 at 2:05 PM, Shay Rojansky <roji@roji.org> wrote:

Sorry about this, I just haven't had a free moment (and it's definitely not
very high priority...)

No issues, just cleaning house.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers