pgbench - compute & show latency consistently
Currently the latency is not computed and displayed consistently:
- the computation is wrong under -t (duration is zero...)
- depending on the conditions it is shown with a ":" syntax or
a "=" syntax.
The attached minor patch makes the computation & display more consistent.
--
Fabien.
Attachments:
pgbench-latency-t-1.patchtext/x-diff; name=pgbench-latency-t-1.patchDownload+6-6
On 7/9/16 4:42 AM, Fabien COELHO wrote:
number of transactions per client: 1000 number of transactions actually processed: 10000/10000 -latency average = 15.844 ms -latency stddev = 2.715 ms +latency average: 15.844 ms +latency stddev: 2.715 ms tps = 618.764555 (including connections establishing) tps = 622.977698 (excluding connections establishing)
I think what you have here is that colons separate input parameters and
equal signs separate result output. So I think it's OK the way it is.
Maybe a better improvement would be introducing section headings like
"test parameters" and "test results".
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Hello Peter,
number of transactions per client: 1000 -latency average = 15.844 ms +latency average: 15.844 ms tps = 618.764555 (including connections establishing)I think what you have here is that colons separate input parameters and
equal signs separate result output. So I think it's OK the way it is.
Hmmm... Then other measures displayed are not all consistent with this
theory.
Also there is still the bug under -t which displays a 0 latency.
The attached patch still fixes that and make it consistent the other way
around, i.e. by using "=" for latency. I switched to use ":" for weight
which is an input parameter. I let ":" when there is a long sentence to
describe the figure displayed, more on aesthetical grounds.
Maybe a better improvement would be introducing section headings like
"test parameters" and "test results".
This would add more lines to the report, to sure how desirable it is.
--
Fabien.
Attachments:
pgbench-latency-t-2.patchtext/x-diff; name=pgbench-latency-t-2.patchDownload+4-4
On 07/13/2016 11:39 AM, Fabien COELHO wrote:
number of transactions per client: 1000 -latency average = 15.844 ms +latency average: 15.844 ms tps = 618.764555 (including connections establishing)I think what you have here is that colons separate input parameters and
equal signs separate result output. So I think it's OK the way it is.Hmmm... Then other measures displayed are not all consistent with this
theory.Also there is still the bug under -t which displays a 0 latency.
The attached patch still fixes that and make it consistent the other way
around, i.e. by using "=" for latency. I switched to use ":" for weight
which is an input parameter. I let ":" when there is a long sentence to
describe the figure displayed, more on aesthetical grounds.
Committed, thanks!
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers