Duplicate prototype for socket_set_nonblocking.
Hello,
Looking into pqcomm.c, I noticed that the prototype of
socket_set_nonblocking defined twice. Actually the prototype is
not necessary at all but one may remain as a convention.
It doesn't no harm so backpatching seems unnecessary.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
0001-Remove-duplicate-prototype-definition-for-socket_set.patchtext/x-patch; charset=us-asciiDownload
From fa8911cbab690c8dc2f8b0d8864dee5470730bbe Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyotaro@lab.ntt.co.jp>
Date: Fri, 29 Jul 2016 10:01:53 +0900
Subject: [PATCH] Remove duplicate prototype definition for
socket_set_nonblocking.
---
src/backend/libpq/pqcomm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
index ba42753..90b6946 100644
--- a/src/backend/libpq/pqcomm.c
+++ b/src/backend/libpq/pqcomm.c
@@ -145,7 +145,6 @@ static void socket_startcopyout(void);
static void socket_endcopyout(bool errorAbort);
static int internal_putbytes(const char *s, size_t len);
static int internal_flush(void);
-static void socket_set_nonblocking(bool nonblocking);
#ifdef HAVE_UNIX_SOCKETS
static int Lock_AF_UNIX(char *unixSocketDir, char *unixSocketPath);
--
1.8.3.1
On Thu, Jul 28, 2016 at 9:12 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
Looking into pqcomm.c, I noticed that the prototype of
socket_set_nonblocking defined twice. Actually the prototype is
not necessary at all but one may remain as a convention.It doesn't no harm so backpatching seems unnecessary.
Thanks, committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers