comment fix for CUSTOMPATH_* flags
Hello,
I noticed the source code comment around CustomPath structure says "see above"
for definition of CUSTOMPATH_* flags. It was originally right, but it was moved
to nodes/extensible.h on the further development. So, no comments are above.
The attached patch corrects the comment for the right location.
Thanks,
--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai@ak.jp.nec.com>
Attachments:
pgsql-v9.6-custom-flags-comments-fixup.patchapplication/octet-stream; name=pgsql-v9.6-custom-flags-comments-fixup.patchDownload
src/include/nodes/execnodes.h | 3 ++-
src/include/nodes/plannodes.h | 3 ++-
src/include/nodes/relation.h | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h
index e7fd7bd..d983a92 100644
--- a/src/include/nodes/execnodes.h
+++ b/src/include/nodes/execnodes.h
@@ -1611,7 +1611,8 @@ struct CustomExecMethods;
typedef struct CustomScanState
{
ScanState ss;
- uint32 flags; /* mask of CUSTOMPATH_* flags, see relation.h */
+ uint32 flags; /* mask of CUSTOMPATH_* flags,
+ * see nodes/extensible.h */
List *custom_ps; /* list of child PlanState nodes, if any */
Size pscan_len; /* size of parallel coordination information */
const struct CustomExecMethods *methods;
diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h
index bc5463b..c84222c 100644
--- a/src/include/nodes/plannodes.h
+++ b/src/include/nodes/plannodes.h
@@ -560,7 +560,8 @@ struct CustomScanMethods;
typedef struct CustomScan
{
Scan scan;
- uint32 flags; /* mask of CUSTOMPATH_* flags, see relation.h */
+ uint32 flags; /* mask of CUSTOMPATH_* flags,
+ * see nodes/extensible.h */
List *custom_plans; /* list of Plan nodes, if any */
List *custom_exprs; /* expressions that custom code may evaluate */
List *custom_private; /* private data for custom code */
diff --git a/src/include/nodes/relation.h b/src/include/nodes/relation.h
index fcfb0d4..a8f27f4 100644
--- a/src/include/nodes/relation.h
+++ b/src/include/nodes/relation.h
@@ -1087,7 +1087,8 @@ struct CustomPathMethods;
typedef struct CustomPath
{
Path path;
- uint32 flags; /* mask of CUSTOMPATH_* flags, see above */
+ uint32 flags; /* mask of CUSTOMPATH_* flags,
+ * see nodes/extensible.h */
List *custom_paths; /* list of child Path nodes, if any */
List *custom_private;
const struct CustomPathMethods *methods;
On Mon, Aug 29, 2016 at 6:04 AM, Kouhei Kaigai <kaigai@ak.jp.nec.com> wrote:
I noticed the source code comment around CustomPath structure says "see above"
for definition of CUSTOMPATH_* flags. It was originally right, but it was moved
to nodes/extensible.h on the further development. So, no comments are above.
The attached patch corrects the comment for the right location.
Committed, thanks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers