Apr 2020

1 commit
Implement waiting for given lsn at transaction start
7 Apr 2020Alexander Korotkovmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #721 of 10 reviewers saw the final version

The commit derives from the jointly authored patch posted by Anna Akenteva in #72, retaining its complete 20-file scope and BEGIN/START TRANSACTION interface; #73 announces the push. Besides renaming and documentation edits, src/backend/commands/wait.c and xlog.c change minimum-LSN sentinel handling, initialize the atomic field, add a replay-position recheck after latch registration, and change polling from 100 milliseconds to one second.

  • Craig Ringersaw an earlier versiontrailerDiscussed the initial patch's consistency goal, obtaining commit LSNs, and alternative transaction identifiers in #2, before substantial interface and implementation changes.
  • Thomas Munrosaw an earlier versiontrailerFound type, timeout, synchronization, and wakeup problems in #4 and #14, and explained the function interface's snapshot problem in #12.
  • Robert Haassaw an earlier versiontrailerCritiqued the function interface's isolation semantics in #16 and the LSN-specific interface in #28, before the later transaction-start implementation.
  • Kyotaro Horiguchisaw an earlier versiontrailerReviewed syntax, interruption behavior, and array-versus-queue wakeups in #50, prompting reconsideration of BEGIN integration before subsequent reworks.
  • Masahiko Sawadasaw an earlier versiontrailerQuestioned the extension implementation and advocated a core feature with further syntax discussion in #11.
  • Ants Aasmasaw an earlier versiontrailerChallenged the LSN-specific interface in #23 and developed opaque-state-token and causal-visibility semantics in #29 and #32.
  • Dmitry Ivanovsaw an earlier versiontrailerReviewed the proposed multi-event semantics in #42, requesting explicit ANY/ALL behavior before that implementation was attached, so no specific reviewed patchset can be identified.
  • Simon Riggssaw an earlier versiontrailerExplicitly reported reviewing the proposal in #36 and requested generalized WAIT FOR events, simpler options, documentation, and TAP tests before the later reworks.
  • Amit Kapilasaw an earlier versiontrailerIdentified error-cleanup and interruption problems and requested return-type and timestamp-helper changes in #67, followed by substantive fixes in #72 and further committer logic changes.
  • Alexander Korotkovsaw the final versiontrailerReviewed syntax and cleanup in #22 and #26, requested the single-LSN transaction-start design in #62, and reviewed the final version as committer, announcing its push in #73.

Credits across 1 commit

Author
Anna Akenteva1
Kartyshov Ivan1
Reviewer
Alexander Korotkov1
Amit Kapila1
Ants Aasma1
Craig Ringer1
Dmitry Ivanov1
Kyotaro Horiguchi1
Masahiko Sawada1
Robert Haas1
Simon Riggs1
Thomas Munro1
Committer
Alexander Korotkov1