[bug fix] pg_recvlogical is missing in the Windows installation
Hello,
pg_recvlogical is not included in the Windows client installation,
which is performed by running "install <instdir> client". The
attached patch based on HEAD fixes this. I confirmed nothing else is
missing in the client installation.
Regards
MauMau (= Takayuki Tsunakawa)
Attachments:
missing_win_modules.patchapplication/octet-stream; name=missing_win_modules.patchDownload
diff -Nacr a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm
*** a/src/tools/msvc/Install.pm 2016-09-18 06:34:55.944178000 +0900
--- b/src/tools/msvc/Install.pm 2016-09-18 06:51:21.469403200 +0900
***************
*** 24,31 ****
'dropdb', 'droplang', 'dropuser', 'ecpg',
'libecpg', 'libecpg_compat', 'libpgtypes', 'libpq',
'pg_basebackup', 'pg_config', 'pg_dump', 'pg_dumpall',
! 'pg_isready', 'pg_receivexlog', 'pg_restore', 'psql',
! 'reindexdb', 'vacuumdb', @client_contribs);
sub lcopy
{
--- 24,31 ----
'dropdb', 'droplang', 'dropuser', 'ecpg',
'libecpg', 'libecpg_compat', 'libpgtypes', 'libpq',
'pg_basebackup', 'pg_config', 'pg_dump', 'pg_dumpall',
! 'pg_isready', 'pg_receivexlog', 'pg_recvlogical', 'pg_restore',
! 'psql', 'reindexdb', 'vacuumdb', @client_contribs);
sub lcopy
{
On Sun, Sep 18, 2016 at 7:01 AM, MauMau <maumau307@gmail.com> wrote:
pg_recvlogical is not included in the Windows client installation,
which is performed by running "install <instdir> client". The
attached patch based on HEAD fixes this. I confirmed nothing else is
missing in the client installation.
Good cacth. This has been missed for a couple of years.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Sat, Sep 17, 2016 at 7:44 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
On Sun, Sep 18, 2016 at 7:01 AM, MauMau <maumau307@gmail.com> wrote:
pg_recvlogical is not included in the Windows client installation,
which is performed by running "install <instdir> client". The
attached patch based on HEAD fixes this. I confirmed nothing else is
missing in the client installation.Good cacth. This has been missed for a couple of years.
OK, committed and back-patched to 9.4. Not having a Windows build
environment, I did that blindly, so hopefully the BF won't blow up....
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas
On Sat, Sep 17, 2016 at 7:44 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
On Sun, Sep 18, 2016 at 7:01 AM, MauMau <maumau307@gmail.com> wrote:
pg_recvlogical is not included in the Windows client installation,
which is performed by running "install <instdir> client". The
attached patch based on HEAD fixes this. I confirmed nothing else
is
missing in the client installation.
Good cacth. This has been missed for a couple of years.
OK, committed and back-patched to 9.4. Not having a Windows build
environment, I did that blindly, so hopefully the BF won't blow up....
Thank you for quick committing.
Regards
MauMau
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers