needlessly casting away const in localtime.c

Started by Mark Dilgerover 9 years ago2 messageshackers
Jump to latest
#1Mark Dilger
mark.dilger@enterprisedb.com

Friends, per the recent thread "gratuitous casting away const", the
assignment on line 1247 of localtime.c has const lvalue and rvalue,
yet casts through (char *) rather than (const char *). Fix attached.

Mark Dilger

Attachments:

localtime.c.patchapplication/octet-stream; name=localtime.c.patchDownload+1-1
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Mark Dilger (#1)
Re: needlessly casting away const in localtime.c

Mark Dilger <hornschnorter@gmail.com> writes:

Friends, per the recent thread "gratuitous casting away const", the
assignment on line 1247 of localtime.c has const lvalue and rvalue,
yet casts through (char *) rather than (const char *). Fix attached.

If you want to propose cosmetic improvements in localtime.c, or the
majority of the other stuff in src/timezone, you need to send it to
the IANA folk. Otherwise it'll just be lost next time we sync with
them. See src/timezone/README.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers