Typo in comment in contrib/postgres_fdw/deparse.c

Started by Etsuro Fujitaabout 9 years ago5 messages
#1Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
1 attachment(s)

Hi,

I ran into a typo in a comment in contrib/postgres_fdw/deparse.c.
Please find attached a patch.

Best regards,
Etsuro Fujita

Attachments:

postgres-fdw-typo-fix.patchapplication/x-patch; name=postgres-fdw-typo-fix.patchDownload
diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c
index 450693a..66b059a 100644
--- a/contrib/postgres_fdw/deparse.c
+++ b/contrib/postgres_fdw/deparse.c
@@ -847,7 +847,7 @@ deparse_type_name(Oid type_oid, int32 typemod)
  *
  * The output targetlist contains the columns that need to be fetched from the
  * foreign server for the given relation.  If foreignrel is an upper relation,
- * then the output targetlist can also contains expressions to be evaluated on
+ * then the output targetlist can also contain expressions to be evaluated on
  * foreign server.
  */
 List *
#2Robert Haas
robertmhaas@gmail.com
In reply to: Etsuro Fujita (#1)
Re: Typo in comment in contrib/postgres_fdw/deparse.c

On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:

I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please
find attached a patch.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
In reply to: Robert Haas (#2)
1 attachment(s)
Re: Typo in comment in contrib/postgres_fdw/deparse.c

On 2016/11/02 5:22, Robert Haas wrote:

On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:

I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please
find attached a patch.

Committed.

Thanks!

I found another typo in postgres_fdw.c. Attached is a patch for fixing
that.

Best regards,
Etsuro Fujita

Attachments:

postgres-fdw-another-typo-fix.patchapplication/x-patch; name=postgres-fdw-another-typo-fix.patchDownload
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c
index 2cfb82b..fbe6929 100644
--- a/contrib/postgres_fdw/postgres_fdw.c
+++ b/contrib/postgres_fdw/postgres_fdw.c
@@ -4156,7 +4156,7 @@ foreign_join_ok(PlannerInfo *root, RelOptInfo *joinrel, JoinType jointype,
 	 * other remote clauses. For LEFT and RIGHT OUTER join, the clauses from
 	 * the outer side are added to remote_conds since those can be evaluated
 	 * after the join is evaluated. The clauses from inner side are added to
-	 * the joinclauses, since they need to evaluated while constructing the
+	 * the joinclauses, since they need to be evaluated while constructing the
 	 * join.
 	 *
 	 * For a FULL OUTER JOIN, the other clauses from either relation can not
#4Robert Haas
robertmhaas@gmail.com
In reply to: Etsuro Fujita (#3)
Re: Typo in comment in contrib/postgres_fdw/deparse.c

On Fri, Nov 4, 2016 at 7:20 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:

On 2016/11/02 5:22, Robert Haas wrote:

On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:

I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please
find attached a patch.

Committed.

Thanks!

I found another typo in postgres_fdw.c. Attached is a patch for fixing
that.

OK, committed that, too.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
In reply to: Robert Haas (#4)
Re: Typo in comment in contrib/postgres_fdw/deparse.c

On 2016/11/04 22:04, Robert Haas wrote:

On Fri, Nov 4, 2016 at 7:20 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:

I found another typo in postgres_fdw.c. Attached is a patch for fixing
that.

OK, committed that, too.

Thanks again!

Best regards,
Etsuro Fujita

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers