A bug of psql completion

Started by Kyotaro Horiguchiover 9 years ago3 messageshackers

Jump to latest

Kyotaro Horiguchi

horikyota.ntt@gmail.com

over 9 years ago

Hello.

I noticed that the psql completion code for "ALTER TABLE x ALTER
[COLUMN] x DROP" is wrong. It works as the following

=# alter table x alter x drop <tab>
[nothing suggested]
=# alter table x table x alter x drop <tab>
DEFAULT NOT NULL

The attached patch fixes it.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Tom Lane

tgl@sss.pgh.pa.us

over 9 years ago

In reply to: Kyotaro Horiguchi (#1)

Re: A bug of psql completion

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:

I noticed that the psql completion code for "ALTER TABLE x ALTER
[COLUMN] x DROP" is wrong. It works as the following

=# alter table x alter x drop <tab>
[nothing suggested]
=# alter table x table x alter x drop <tab>
DEFAULT NOT NULL

The attached patch fixes it.

Pushed, thanks.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Kyotaro Horiguchi

horikyota.ntt@gmail.com

over 9 years ago

In reply to: Tom Lane (#2)

Re: A bug of psql completion

At Mon, 28 Nov 2016 11:52:07 -0500, Tom Lane <tgl@sss.pgh.pa.us> wrote in <4624.1480351927@sss.pgh.pa.us>
tgl> Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
tgl> > I noticed that the psql completion code for "ALTER TABLE x ALTER
tgl> > [COLUMN] x DROP" is wrong. It works as the following
...
tgl> > The attached patch fixes it.
tgl>
tgl> Pushed, thanks.

Thanks for committing.

--
Kyotaro Horiguchi
NTT Open Source Software Center

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

A bug of psql completion

Attachments: