The max value of autovacuum_vacuum/analyze_scale_factor.

Started by Masahiko Sawadaabout 9 years ago3 messages
#1Masahiko Sawada
sawada.mshk@gmail.com
1 attachment(s)

Hi all,

Is there any reason why the max values of
autovacuum_vacuum/analyze_scale_factor are 100.0? These max values are
defined since when the parameters has been introduced but I think that
1.0 is enough.

Patch attached.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachments:

change_max_limit_of_scale_factors_.patchapplication/octet-stream; name=change_max_limit_of_scale_factors_.patchDownload
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 4e49d5b..776cae3 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -2963,7 +2963,7 @@ static struct config_real ConfigureNamesReal[] =
 			NULL
 		},
 		&autovacuum_vac_scale,
-		0.2, 0.0, 100.0,
+		0.2, 0.0, 1.0,
 		NULL, NULL, NULL
 	},
 	{
@@ -2972,7 +2972,7 @@ static struct config_real ConfigureNamesReal[] =
 			NULL
 		},
 		&autovacuum_anl_scale,
-		0.1, 0.0, 100.0,
+		0.1, 0.0, 1.0,
 		NULL, NULL, NULL
 	},
 
#2Ashutosh Bapat
ashutosh.bapat@enterprisedb.com
In reply to: Masahiko Sawada (#1)
Re: The max value of autovacuum_vacuum/analyze_scale_factor.

On Mon, Dec 5, 2016 at 4:44 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:

Hi all,

Is there any reason why the max values of
autovacuum_vacuum/analyze_scale_factor are 100.0? These max values are
defined since when the parameters has been introduced but I think that
1.0 is enough.

Yes, at least from
https://www.postgresql.org/docs/devel/static/runtime-config-autovacuum.html,
it looks like this is supposed to be a "fraction of table size".
anything higher than 1.0 isn't a fraction. If at all any value > 1.0
has a meaning, I am wondering whether it's to account for bloat. But
then who would want to place the threashold in bloated area.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Ashutosh Bapat (#2)
Re: The max value of autovacuum_vacuum/analyze_scale_factor.

On Mon, Dec 5, 2016 at 9:15 PM, Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:

On Mon, Dec 5, 2016 at 4:44 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:

Hi all,

Is there any reason why the max values of
autovacuum_vacuum/analyze_scale_factor are 100.0? These max values are
defined since when the parameters has been introduced but I think that
1.0 is enough.

Yes, at least from
https://www.postgresql.org/docs/devel/static/runtime-config-autovacuum.html,
it looks like this is supposed to be a "fraction of table size".
anything higher than 1.0 isn't a fraction. If at all any value > 1.0
has a meaning, I am wondering whether it's to account for bloat. But
then who would want to place the threashold in bloated area.

I understand that use case.
Thank you!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers