comments tablecmds.c

Started by Erik Rijkersabout 9 years ago5 messages
#1Erik Rijkers
er@xs4all.nl
1 attachment(s)

'the the' -> 'the'

and

'ie' -> 'i.e.'

Although (concening the latter change) the present counts are 'ie' 428,
and 'i.e.' 428.
so it might be debatable (but let's not)

thanks,

Erik Rijkers

Attachments:

tablecmds.c.difftext/x-diff; name=tablecmds.c.diffDownload
--- src/backend/commands/tablecmds.c.orig	2016-12-25 13:29:28.715237491 +0100
+++ src/backend/commands/tablecmds.c	2016-12-25 13:31:03.244444936 +0100
@@ -13244,7 +13244,7 @@
 			skip_validate = true;
 
 		/*
-		 * We choose to err on the safer side, ie, give up on skipping the the
+		 * We choose to err on the safer side, i.e., give up on skipping the
 		 * validation scan, if the partition key column doesn't have the NOT
 		 * NULL constraint and the table is to become a list partition that
 		 * does not accept nulls.  In this case, the partition predicate
#2Erik Rijkers
er@xs4all.nl
In reply to: Erik Rijkers (#1)
Re: comments tablecmds.c

On 2016-12-25 13:38, Erik Rijkers wrote:

'the the' -> 'the'

and

'ie' -> 'i.e.'

Although (concening the latter change) the present counts are 'ie'
428, and 'i.e.' 428.
so it might be debatable (but let's not)

Sorry; I meant: 'ie' 428, and 'i.e.' 305.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Magnus Hagander
magnus@hagander.net
In reply to: Erik Rijkers (#2)
Re: comments tablecmds.c

On Sun, Dec 25, 2016 at 2:35 PM, Erik Rijkers <er@xs4all.nl> wrote:

On 2016-12-25 13:38, Erik Rijkers wrote:

'the the' -> 'the'

and

'ie' -> 'i.e.'

Although (concening the latter change) the present counts are 'ie'
428, and 'i.e.' 428.
so it might be debatable (but let's not)

Sorry; I meant: 'ie' 428, and 'i.e.' 305.

Applied, thanks.

Seems to me that in comments it's not worth chasing them down individually,
but if you happen to fix one alongside another one like here, then it's a
different story :)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

#4Erik Rijkers
er@xs4all.nl
In reply to: Magnus Hagander (#3)
Re: comments tablecmds.c

On 2016-12-27 10:25, Magnus Hagander wrote:

On Sun, Dec 25, 2016 at 2:35 PM, Erik Rijkers <er@xs4all.nl> wrote:

Applied, thanks.

Seems to me that in comments it's not worth chasing them down
individually,
but if you happen to fix one alongside another one like here, then it's
a
different story :)

Well, it had been triggering my (very simple) spell-checker at each
compile, for a month a so. I just wanted to silence it :)

Thanks for doing that :)

Erik Rijkers

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Magnus Hagander
magnus@hagander.net
In reply to: Erik Rijkers (#4)
Re: comments tablecmds.c

On Tue, Dec 27, 2016 at 10:36 AM, Erik Rijkers <er@xs4all.nl> wrote:

On 2016-12-27 10:25, Magnus Hagander wrote:

On Sun, Dec 25, 2016 at 2:35 PM, Erik Rijkers <er@xs4all.nl> wrote:

Applied, thanks.

Seems to me that in comments it's not worth chasing them down
individually,
but if you happen to fix one alongside another one like here, then it's a
different story :)

Well, it had been triggering my (very simple) spell-checker at each
compile, for a month a so. I just wanted to silence it :)

Thanks for doing that :)

FWIW, that comment was in reference to the i.e. vs ie. The "the the"
problem was definitely something to fix :)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/