use SQL standard error code for nextval

Started by Peter Eisentrautabout 9 years ago5 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

The SQL standard defines a separate error code for nextval exhausting
the sequence space. I haven't found any discussion of this in the
archives, so it seems this was just not considered or not yet in
existence when the error codes were introduced. Here is a patch to
correct it.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

0001-Use-SQL-standard-error-code-for-nextval.patchtext/x-patch; name=0001-Use-SQL-standard-error-code-for-nextval.patchDownload+3-3
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Peter Eisentraut (#1)
Re: use SQL standard error code for nextval

On 2/28/17 22:15, Peter Eisentraut wrote:

The SQL standard defines a separate error code for nextval exhausting
the sequence space. I haven't found any discussion of this in the
archives, so it seems this was just not considered or not yet in
existence when the error codes were introduced. Here is a patch to
correct it.

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Mark Dilger
mark.dilger@enterprisedb.com
In reply to: Peter Eisentraut (#2)
Re: use SQL standard error code for nextval

On Mar 9, 2017, at 7:59 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:

On 2/28/17 22:15, Peter Eisentraut wrote:

The SQL standard defines a separate error code for nextval exhausting
the sequence space. I haven't found any discussion of this in the
archives, so it seems this was just not considered or not yet in
existence when the error codes were introduced. Here is a patch to
correct it.

committed

Perhaps you should add something to the release notes. Somebody could be
testing for the old error code.

Mark Dilger

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Mark Dilger (#3)
Re: use SQL standard error code for nextval

On 3/9/17 12:27, Mark Dilger wrote:

Perhaps you should add something to the release notes. Somebody could be
testing for the old error code.

The release notes will be written when the release is prepared.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Tom Lane
tgl@sss.pgh.pa.us
In reply to: Mark Dilger (#3)
Re: use SQL standard error code for nextval

Mark Dilger <hornschnorter@gmail.com> writes:

On Mar 9, 2017, at 7:59 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
On 2/28/17 22:15, Peter Eisentraut wrote:

The SQL standard defines a separate error code for nextval exhausting
the sequence space. I haven't found any discussion of this in the
archives, so it seems this was just not considered or not yet in
existence when the error codes were introduced. Here is a patch to
correct it.

Perhaps you should add something to the release notes. Somebody could be
testing for the old error code.

The release notes for v10 aren't going to be drafted for months yet.
When they are, hopefully the writer will notice that this should be
listed as an incompatible change. That's not the responsibility
of this commit, although it would've been better if the commit log
entry explicitly pointed out that it's an incompatible change.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers